Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/search_engines/template_url_unittest.cc

Issue 316963002: Move branding information out of google_util (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/base_paths.h" 5 #include "base/base_paths.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
11 #include "chrome/browser/rlz/rlz.h" 11 #include "chrome/browser/rlz/rlz.h"
12 #include "chrome/browser/search_engines/search_terms_data.h" 12 #include "chrome/browser/search_engines/search_terms_data.h"
13 #include "chrome/browser/search_engines/template_url.h" 13 #include "chrome/browser/search_engines/template_url.h"
14 #include "chrome/common/chrome_switches.h" 14 #include "chrome/common/chrome_switches.h"
15 #include "chrome/common/chrome_version_info.h" 15 #include "chrome/common/chrome_version_info.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 17
18 #if defined(ENABLE_RLZ) 18 #if defined(ENABLE_RLZ)
19 #include "chrome/browser/google/google_brand.h"
19 #include "chrome/browser/google/google_util.h" 20 #include "chrome/browser/google/google_util.h"
20 #endif 21 #endif
21 22
22 #if defined(OS_ANDROID) 23 #if defined(OS_ANDROID)
23 #include "chrome/browser/search_engines/search_terms_data_android.h" 24 #include "chrome/browser/search_engines/search_terms_data_android.h"
24 #endif 25 #endif
25 26
26 using base::ASCIIToUTF16; 27 using base::ASCIIToUTF16;
27 28
28 // TestSearchTermsData -------------------------------------------------------- 29 // TestSearchTermsData --------------------------------------------------------
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 GURL result(url.url_ref().ReplaceSearchTerms(search_terms_args)); 652 GURL result(url.url_ref().ReplaceSearchTerms(search_terms_args));
652 ASSERT_TRUE(result.is_valid()); 653 ASSERT_TRUE(result.is_valid());
653 EXPECT_EQ(test_data[i].expected_result, result.spec()); 654 EXPECT_EQ(test_data[i].expected_result, result.spec());
654 } 655 }
655 } 656 }
656 657
657 TEST_F(TemplateURLTest, RLZ) { 658 TEST_F(TemplateURLTest, RLZ) {
658 base::string16 rlz_string; 659 base::string16 rlz_string;
659 #if defined(ENABLE_RLZ) 660 #if defined(ENABLE_RLZ)
660 std::string brand; 661 std::string brand;
661 if (google_util::GetBrand(&brand) && !brand.empty() && 662 if (google_brand::GetBrand(&brand) && !brand.empty() &&
662 !google_util::IsOrganic(brand)) { 663 !google_brand::IsOrganic(brand)) {
663 RLZTracker::GetAccessPointRlz(RLZTracker::ChromeOmnibox(), &rlz_string); 664 RLZTracker::GetAccessPointRlz(RLZTracker::ChromeOmnibox(), &rlz_string);
664 } 665 }
665 #elif defined(OS_ANDROID) 666 #elif defined(OS_ANDROID)
666 SearchTermsDataAndroid::rlz_parameter_value_.Get() = 667 SearchTermsDataAndroid::rlz_parameter_value_.Get() =
667 ASCIIToUTF16("android_test"); 668 ASCIIToUTF16("android_test");
668 rlz_string = SearchTermsDataAndroid::rlz_parameter_value_.Get(); 669 rlz_string = SearchTermsDataAndroid::rlz_parameter_value_.Get();
669 #endif 670 #endif
670 671
671 TemplateURLData data; 672 TemplateURLData data;
672 data.SetURL("http://bar/?{google:RLZ}{searchTerms}"); 673 data.SetURL("http://bar/?{google:RLZ}{searchTerms}");
673 TemplateURL url(NULL, data); 674 TemplateURL url(NULL, data);
674 EXPECT_TRUE(url.url_ref().IsValid()); 675 EXPECT_TRUE(url.url_ref().IsValid());
675 ASSERT_TRUE(url.url_ref().SupportsReplacement()); 676 ASSERT_TRUE(url.url_ref().SupportsReplacement());
676 GURL result(url.url_ref().ReplaceSearchTerms( 677 GURL result(url.url_ref().ReplaceSearchTerms(
677 TemplateURLRef::SearchTermsArgs(ASCIIToUTF16("x")))); 678 TemplateURLRef::SearchTermsArgs(ASCIIToUTF16("x"))));
678 ASSERT_TRUE(result.is_valid()); 679 ASSERT_TRUE(result.is_valid());
679 std::string expected_url = "http://bar/?"; 680 std::string expected_url = "http://bar/?";
680 if (!rlz_string.empty()) 681 if (!rlz_string.empty())
681 expected_url += "rlz=" + base::UTF16ToUTF8(rlz_string) + "&"; 682 expected_url += "rlz=" + base::UTF16ToUTF8(rlz_string) + "&";
682 expected_url += "x"; 683 expected_url += "x";
683 EXPECT_EQ(expected_url, result.spec()); 684 EXPECT_EQ(expected_url, result.spec());
684 } 685 }
685 686
686 #if !defined(OS_ANDROID) && !defined(OS_IOS) 687 #if !defined(OS_ANDROID) && !defined(OS_IOS)
687 TEST_F(TemplateURLTest, RLZFromAppList) { 688 TEST_F(TemplateURLTest, RLZFromAppList) {
688 base::string16 rlz_string; 689 base::string16 rlz_string;
689 #if defined(ENABLE_RLZ) 690 #if defined(ENABLE_RLZ)
690 std::string brand; 691 std::string brand;
691 if (google_util::GetBrand(&brand) && !brand.empty() && 692 if (google_brand::GetBrand(&brand) && !brand.empty() &&
692 !google_util::IsOrganic(brand)) { 693 !google_brand::IsOrganic(brand)) {
693 RLZTracker::GetAccessPointRlz(RLZTracker::ChromeAppList(), &rlz_string); 694 RLZTracker::GetAccessPointRlz(RLZTracker::ChromeAppList(), &rlz_string);
694 } 695 }
695 #endif 696 #endif
696 697
697 TemplateURLData data; 698 TemplateURLData data;
698 data.SetURL("http://bar/?{google:RLZ}{searchTerms}"); 699 data.SetURL("http://bar/?{google:RLZ}{searchTerms}");
699 TemplateURL url(NULL, data); 700 TemplateURL url(NULL, data);
700 EXPECT_TRUE(url.url_ref().IsValid()); 701 EXPECT_TRUE(url.url_ref().IsValid());
701 ASSERT_TRUE(url.url_ref().SupportsReplacement()); 702 ASSERT_TRUE(url.url_ref().SupportsReplacement());
702 TemplateURLRef::SearchTermsArgs args(ASCIIToUTF16("x")); 703 TemplateURLRef::SearchTermsArgs args(ASCIIToUTF16("x"));
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
1351 TemplateURLRef::SearchTermsArgs search_terms_args(ASCIIToUTF16("foo")); 1352 TemplateURLRef::SearchTermsArgs search_terms_args(ASCIIToUTF16("foo"));
1352 search_terms_args.session_token = "SESSIONTOKENGOESHERE"; 1353 search_terms_args.session_token = "SESSIONTOKENGOESHERE";
1353 std::string result = url.url_ref().ReplaceSearchTerms(search_terms_args); 1354 std::string result = url.url_ref().ReplaceSearchTerms(search_terms_args);
1354 EXPECT_EQ("http://bar/search?q=foo&psi=SESSIONTOKENGOESHERE&xssi=t", result); 1355 EXPECT_EQ("http://bar/search?q=foo&psi=SESSIONTOKENGOESHERE&xssi=t", result);
1355 1356
1356 TemplateURL url2(NULL, data); 1357 TemplateURL url2(NULL, data);
1357 search_terms_args.session_token = ""; 1358 search_terms_args.session_token = "";
1358 result = url.url_ref().ReplaceSearchTerms(search_terms_args); 1359 result = url.url_ref().ReplaceSearchTerms(search_terms_args);
1359 EXPECT_EQ("http://bar/search?q=foo&xssi=t", result); 1360 EXPECT_EQ("http://bar/search?q=foo&xssi=t", result);
1360 } 1361 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698