Move branding information out of google_util

Move branding information out of google_util

google_util is intended for componentization, whereas the information of what
the current brand is and whether a given brand is organic is inherently
embedder-specific. This functionality is moved to a new google_brand namespace.

BUG=373224
TBR=jochen

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275413

[Peter Kasting, 2014-06-04 20:32:15]

Everywhere you've added a google_brand.h #include, please verify that the
existing google_util.h #include is still necessary and can't be eliminated.

LGTM otherwise.

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
File chrome/browser/google/google_brand.cc (right):

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.cc:23: #include "url/gurl.h"
Are all these truly necessary?  For example, you don't seem to use the registry
controlled domain stuff, or string_split, or the string_number_conversions.

Please eliminate all headers not actually necessary in this file.

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.cc:36: const char* brand_for_testing = NULL;
Nit: I'd prefix this with g_

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
File chrome/browser/google/google_brand.h (right):

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.h:5: // Some Google related utility
functions.
Can you clarify and expand this comment?  This is no longer just random
utilities, they all have to do with branding.  Maybe explain a bit about what a
brand is and who might care?

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.h:17: // distributions (such as RLZ).
Nit: I'd drop this and say anything necessary in the file comment above.

[blundell, 2014-06-05 09:21:41]

Thanks for the review, CL is much cleaner now!

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
File chrome/browser/google/google_brand.cc (right):

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.cc:23: #include "url/gurl.h"
On 2014/06/04 20:32:16, Peter Kasting wrote:
> Are all these truly necessary?  For example, you don't seem to use the
registry
> controlled domain stuff, or string_split, or the string_number_conversions.
> 
> Please eliminate all headers not actually necessary in this file.

Done.

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.cc:36: const char* brand_for_testing = NULL;
On 2014/06/04 20:32:16, Peter Kasting wrote:
> Nit: I'd prefix this with g_

Done.

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
File chrome/browser/google/google_brand.h (right):

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.h:5: // Some Google related utility
functions.
On 2014/06/04 20:32:16, Peter Kasting wrote:
> Can you clarify and expand this comment?  This is no longer just random
> utilities, they all have to do with branding.  Maybe explain a bit about what
a
> brand is and who might care?

Done.

https://codereview.chromium.org/316963002/diff/40001/chrome/browser/google/go...
chrome/browser/google/google_brand.h:17: // distributions (such as RLZ).
On 2014/06/04 20:32:16, Peter Kasting wrote:
> Nit: I'd drop this and say anything necessary in the file comment above.

Done.

[blundell, 2014-06-05 09:23:47]

TBR=jochen for //chrome changes outside of //chrome/browser/google

[blundell, 2014-06-05 09:24:08]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-05 09:29:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/316963002/60001

[commit-bot: I haz the power, 2014-06-05 10:05:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/13303)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16389)

[commit-bot: I haz the power, 2014-06-05 10:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 10:09:37]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[blundell, 2014-06-05 14:13:58]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-05 14:15:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/316963002/80001

[commit-bot: I haz the power, 2014-06-05 18:40:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16495)

[commit-bot: I haz the power, 2014-06-05 20:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 20:08:39]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16560)

[blundell, 2014-06-05 20:25:30]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-05 20:26:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/316963002/80001

[jochen (gone - plz use gerrit), 2014-06-06 07:07:41]

lgtm

[commit-bot: I haz the power, 2014-06-06 08:02:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16820)

[blundell, 2014-06-06 08:13:32]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-06 08:14:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/316963002/100001

[commit-bot: I haz the power, 2014-06-06 11:41:32]

Change committed as 275413