Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 316933005: Remove Android flag for legacy SkCanvas::drawPicture API (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
scroggo, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove Android flag for legacy SkCanvas::drawPicture API Android should no longer need this flag Committed: https://skia.googlesource.com/skia/+/1a0a86f0726742a09586d57663dd40600e9761d9

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-04 18:14:22 UTC) #1
djsollen
lgtm
6 years, 6 months ago (2014-06-04 18:14:53 UTC) #2
scroggo
lgtm https://codereview.chromium.org/316933005/diff/1/gyp/skia_for_android_framework_defines.gypi File gyp/skia_for_android_framework_defines.gypi (left): https://codereview.chromium.org/316933005/diff/1/gyp/skia_for_android_framework_defines.gypi#oldcode23 gyp/skia_for_android_framework_defines.gypi:23: 'SK_SUPPORT_LEGACY_DRAWPICTURE_API', Does Chrome still need this flag? Can ...
6 years, 6 months ago (2014-06-04 18:15:35 UTC) #3
robertphillips
> Does Chrome still need this flag? Can we delete the flag entirely yet? Have ...
6 years, 6 months ago (2014-06-04 18:22:50 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-04 18:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/316933005/1
6 years, 6 months ago (2014-06-04 18:23:51 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 18:43:46 UTC) #7
Message was sent while issue was closed.
Change committed as 1a0a86f0726742a09586d57663dd40600e9761d9

Powered by Google App Engine
This is Rietveld 408576698