Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 316933003: Deflake fast/text/decorations-transformed.html on Win7 (Closed)

Created:
6 years, 6 months ago by eae
Modified:
6 years, 6 months ago
Reviewers:
dglazkov, eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Deflake fast/text/decorations-transformed.html on Win7 Change fast/text/decorations-transformed.html to use the Ahem font instead of ahem as test-only side-loaded fonts are case sensetive on Windows. Also fix similar issue in line-break-after-question-mark test. BUG=378610 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/text/decorations-transformed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/script-tests/line-break-after-question-mark.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
eae
6 years, 6 months ago (2014-06-04 14:34:46 UTC) #1
eseidel
Seems odd that 'ahem' would perform one way and 'Ahem' another. Do we follow CSS3 ...
6 years, 6 months ago (2014-06-04 14:39:54 UTC) #2
eae
On 2014/06/04 14:39:54, eseidel wrote: > Seems odd that 'ahem' would perform one way and ...
6 years, 6 months ago (2014-06-04 14:44:59 UTC) #3
eae
(see https://codereview.chromium.org/291853004/ for background)
6 years, 6 months ago (2014-06-04 14:46:39 UTC) #4
eseidel
OK. Can we make DRT ASSERT or otherwise go down in a blaze of glory ...
6 years, 6 months ago (2014-06-04 14:48:31 UTC) #5
eae
On 2014/06/04 14:48:31, eseidel wrote: > OK. Can we make DRT ASSERT or otherwise go ...
6 years, 6 months ago (2014-06-04 14:50:25 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-04 15:37:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/316933003/1
6 years, 6 months ago (2014-06-04 15:38:39 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 16:23:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 17:46:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/10992)
6 years, 6 months ago (2014-06-04 17:46:39 UTC) #11
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-04 17:47:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/316933003/1
6 years, 6 months ago (2014-06-04 17:48:38 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 19:07:50 UTC) #14
Message was sent while issue was closed.
Change committed as 175509

Powered by Google App Engine
This is Rietveld 408576698