Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 3169019: Fix failing sync integration tests. (Closed)

Created:
8 years, 6 months ago by Raghu Simha
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Fix failing sync integration tests. TwoClientLivePreferencesSyncTest.Security was failing due to a couple of EXPECT_NEs that ought to have been EXPECT_EQs. TwoClientLiveAutofillSyncTest.Client1HasData was failing due to a change in autofill behavior introduced in r55781 to fix security bug crbug.com/51727. This changelist also includes a clarification in the logic used by TwoClientLiveAutofillSyncTest.BothHaveData. BUG=51727, 51956 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/test/live_sync/two_client_live_autofill_sync_test.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M chrome/test/live_sync/two_client_live_preferences_sync_test.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
8 years, 6 months ago (2010-08-17 22:48:59 UTC) #1
tim (not reviewing)
8 years, 6 months ago (2010-08-18 00:17:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698