Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 316883002: Remove special case in HTTP header flattening in WebURLLoaderImpl (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
Reviewers:
jam, ppi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove special case in HTTP header flattening in WebURLLoaderImpl Following https://chromiumcodereview.appspot.com/318673002/ blink will no longer be setting cache headers, so the special case that skips over cache headers is not needed anymore. BUG=376025

Patch Set 1 #

Patch Set 2 : Fixed compilation error on clamg #

Patch Set 3 : Fix the compilation issue for real #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M content/child/web_url_loader_impl.cc View 1 2 4 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
clamy
@ppi: Yay 5th patch! PTAL
6 years, 6 months ago (2014-06-04 11:53:11 UTC) #1
ppi
yay lgtm, thanks!
6 years, 6 months ago (2014-06-04 16:24:31 UTC) #2
clamy
@jam: PTAL. This is the last patch aimed at removing the setting of cache headers ...
6 years, 6 months ago (2014-06-04 16:40:23 UTC) #3
jam
lgtm
6 years, 6 months ago (2014-06-04 18:06:15 UTC) #4
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-05 19:43:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/316883002/1
6 years, 6 months ago (2014-06-05 19:45:39 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 00:53:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 01:04:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/149324)
6 years, 6 months ago (2014-06-06 01:04:18 UTC) #9
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-06 09:22:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/316883002/20001
6 years, 6 months ago (2014-06-06 09:25:52 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 12:55:56 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 13:05:40 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/14284)
6 years, 6 months ago (2014-06-06 13:05:41 UTC) #14
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-06 13:51:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/316883002/40001
6 years, 6 months ago (2014-06-06 13:52:07 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:32:36 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 17:32:37 UTC) #18
Could not make sense out of svn commit message.

Powered by Google App Engine
This is Rietveld 408576698