Interface plus stub implementation for PrivetV3CryptoProvider

Interface plus stub implementation for PrivetV3CryptoProvider

This is a class to handle the session handshake logic as well as encryption with
session key. The stub implementation for session type "empty" does nothing and
passes the data unencrypted.

BUG=380795
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275635

[Vitaly Buka (NO REVIEWS), 2014-06-04 18:34:46]

pretty sure we would need to change this significantly.

https://codereview.chromium.org/316873004/diff/1/chrome/browser/local_discove...
File chrome/browser/local_discovery/privetv3_crypto_provider.cc (right):

https://codereview.chromium.org/316873004/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/privetv3_crypto_provider.cc:48: *package =
std::string();
package->clear()

https://codereview.chromium.org/316873004/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/privetv3_crypto_provider.cc:54: return step == 0
&& package == std::string();
package.empty()

[Vitaly Buka (NO REVIEWS), 2014-06-04 18:34:50]

lgtm

[Vitaly Buka (NO REVIEWS), 2014-06-04 18:35:38]

On 2014/06/04 18:34:50, Vitaly Buka wrote:
> lgtm

Please create bug for encryption and attach here.

[Noam Samuel, 2014-06-04 18:44:38]

Added bug.

https://codereview.chromium.org/316873004/diff/1/chrome/browser/local_discove...
File chrome/browser/local_discovery/privetv3_crypto_provider.cc (right):

https://codereview.chromium.org/316873004/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/privetv3_crypto_provider.cc:48: *package =
std::string();
On 2014/06/04 18:34:46, Vitaly Buka wrote:
> package->clear()

Done.

https://codereview.chromium.org/316873004/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/privetv3_crypto_provider.cc:54: return step == 0
&& package == std::string();
On 2014/06/04 18:34:46, Vitaly Buka wrote:
> package.empty()

Done.

[Noam Samuel, 2014-06-04 18:44:43]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-06-04 18:46:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/316873004/20001

[commit-bot: I haz the power, 2014-06-04 22:42:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-05 06:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 06:17:46]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[Vitaly Buka (NO REVIEWS), 2014-06-05 07:50:00]

https://codereview.chromium.org/316873004/diff/20001/chrome/browser/local_dis...
File chrome/browser/local_discovery/privetv3_crypto_provider.h (right):

https://codereview.chromium.org/316873004/diff/20001/chrome/browser/local_dis...
chrome/browser/local_discovery/privetv3_crypto_provider.h:23: virtual const
std::string& GetAuthMethod() = 0;
const std::string& -> std::string

const ref makes assumption that auth method is stored as member.

[Noam Samuel, 2014-06-05 17:45:52]

Just realized this doesn't account for on-screen verification. Will add that to
interface today.

[Vitaly Buka (NO REVIEWS), 2014-06-05 17:57:13]

On 2014/06/05 17:45:52, Noam Samuel wrote:
> Just realized this doesn't account for on-screen verification. Will add that
to
> interface today.

up to you, just fixing build is enough, we can fix interface on the go

[Noam Samuel, 2014-06-05 20:43:37]

Hey, updated the interface and I think it matches the protocol more. PTAL?

[Vitaly Buka (NO REVIEWS), 2014-06-05 21:07:31]

lgtm

[commit-bot: I haz the power, 2014-06-06 01:13:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16714)

[commit-bot: I haz the power, 2014-06-06 02:01:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 02:01:54]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16779)

[Vitaly Buka (NO REVIEWS), 2014-06-06 03:43:11]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-06-06 03:43:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/316873004/40001

[commit-bot: I haz the power, 2014-06-06 07:05:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16869)

[commit-bot: I haz the power, 2014-06-06 07:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 07:55:20]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16881)

[Vitaly Buka (NO REVIEWS), 2014-06-06 17:33:30]

https://codereview.chromium.org/316873004/diff/40001/chrome/browser/local_dis...
File chrome/browser/local_discovery/privetv3_crypto_provider.h (right):

https://codereview.chromium.org/316873004/diff/40001/chrome/browser/local_dis...
chrome/browser/local_discovery/privetv3_crypto_provider.h:31: ERROR
ERROR -> HANDSHAKE_ERROR or something else
there is conflict on ERROR on windows

[Noam Samuel, 2014-06-06 21:57:36]

https://codereview.chromium.org/316873004/diff/40001/chrome/browser/local_dis...
File chrome/browser/local_discovery/privetv3_crypto_provider.h (right):

https://codereview.chromium.org/316873004/diff/40001/chrome/browser/local_dis...
chrome/browser/local_discovery/privetv3_crypto_provider.h:31: ERROR
On 2014/06/06 17:33:30, Vitaly Buka wrote:
> ERROR -> HANDSHAKE_ERROR or something else
> there is conflict on ERROR on windows

Done.

[Noam Samuel, 2014-06-06 21:57:39]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-06-06 21:58:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/316873004/60001

[commit-bot: I haz the power, 2014-06-07 01:42:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-07 06:34:58]

Change committed as 275635