Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 316863004: Battery Status API: add UMA logging for Android. (Closed)

Created:
6 years, 6 months ago by timvolodine
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org, jar+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Battery Status API: add UMA logging for Android. Count the usage of the Battery Status API on Android. Upon each start of Battery Status API we log if the request to register for battery change updates was successfull or not. BUG=122593, 360068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277041

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed Michael's comment + rebase #

Total comments: 2

Patch Set 3 : fixed enum value type and name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M content/browser/battery_status/battery_status_manager_android.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
timvolodine
6 years, 6 months ago (2014-06-04 16:09:26 UTC) #1
Michael van Ouwerkerk
lgtm https://codereview.chromium.org/316863004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/316863004/diff/1/tools/metrics/histograms/histograms.xml#newcode1755 tools/metrics/histograms/histograms.xml:1755: + Whether the battery information was available at ...
6 years, 6 months ago (2014-06-04 16:21:48 UTC) #2
timvolodine
thanks Michael https://codereview.chromium.org/316863004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/316863004/diff/1/tools/metrics/histograms/histograms.xml#newcode1755 tools/metrics/histograms/histograms.xml:1755: + Whether the battery information was available ...
6 years, 6 months ago (2014-06-05 11:49:12 UTC) #3
timvolodine
+ isherman@ for histograms.xml
6 years, 6 months ago (2014-06-05 11:52:07 UTC) #4
Ilya Sherman
histograms lgtm with a nit: https://codereview.chromium.org/316863004/diff/10001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/316863004/diff/10001/tools/metrics/histograms/histograms.xml#newcode1755 tools/metrics/histograms/histograms.xml:1755: + Whether the Battery ...
6 years, 6 months ago (2014-06-06 07:18:04 UTC) #5
timvolodine
thanks for the comment Ilya! https://codereview.chromium.org/316863004/diff/10001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/316863004/diff/10001/tools/metrics/histograms/histograms.xml#newcode1755 tools/metrics/histograms/histograms.xml:1755: + Whether the Battery ...
6 years, 6 months ago (2014-06-06 12:35:49 UTC) #6
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 6 months ago (2014-06-13 15:46:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/316863004/30001
6 years, 6 months ago (2014-06-13 15:47:34 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 16:53:12 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 17:13:08 UTC) #10
Message was sent while issue was closed.
Change committed as 277041

Powered by Google App Engine
This is Rietveld 408576698