Autofill's "Clear Form" should clear only autofilled fields

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
@@ skipping 2942 matching lines @@
       "</FORM>");
 
   WebFrame* web_frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
 
   FormCache form_cache;
   std::vector<FormData> forms;
   form_cache.ExtractNewForms(*web_frame, &forms);
   ASSERT_EQ(1U, forms.size());
 
-  // Set the auto-filled attribute on the firstname element.
+  // Set the auto-filled attribute.
   WebInputElement firstname =
       web_frame->document().getElementById("firstname").to<WebInputElement>();
   firstname.setAutofilled(true);
 

[Ilya Sherman, 2014/06/16 21:19:37]

nit: I'd avoid these blank lines for the various elements for which you're
setting the autofilled attribute to be true, since the comment on line 2963 is
meant to describe the entire block.

[Nikhil, 2014/06/17 08:59:43]

Done.

+  WebInputElement lastname =
+      web_frame->document().getElementById("lastname").to<WebInputElement>();
+  lastname.setAutofilled(true);
+
+  WebInputElement no_autocomplete =
+      web_frame->document().getElementById("noAC").to<WebInputElement>();
+  no_autocomplete.setAutofilled(true);

[Ilya Sherman, 2014/06/16 21:19:37]

It doesn't really make sense to set autofilled to true for the
autocomplete="off" elements, because those should never be autofilled.  So, this
part of the behavior of the existing test cases should actually change, as
they're otherwise testing something unrealistic.

[Nikhil, 2014/06/17 08:59:43]

Right! I've updated the behavior. Since these fields won't be cleared now
because of change in behavior by this change, I'm now comparing against original
value instead of empty string. Please let me know whether this is okay.

On 2014/06/16 21:19:37, Ilya Sherman wrote:

+
+  WebInputElement month =
+      web_frame->document().getElementById("month").to<WebInputElement>();
+  month.setAutofilled(true);
+
+  WebInputElement textarea =
+      web_frame->document().getElementById("textarea").to<WebInputElement>();
+  textarea.setAutofilled(true);
+
+  WebInputElement textarea_no_autocomplete =
+      web_frame->document()
+          .getElementById("textarea-noAC")
+          .to<WebInputElement>();
+  textarea_no_autocomplete.setAutofilled(true);
+
   // Set the value of the disabled text input element.
   WebInputElement notenabled =
       web_frame->document().getElementById("notenabled").to<WebInputElement>();
   notenabled.setValue(WebString::fromUTF8("no clear"));
 
   // Clear the form.
   EXPECT_TRUE(form_cache.ClearFormWithElement(firstname));
 
   // Verify that the auto-filled attribute has been turned off.
   EXPECT_FALSE(firstname.isAutofilled());
@@ skipping 79 matching lines @@
       "</FORM>");
 
   WebFrame* web_frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
 
   FormCache form_cache;
   std::vector<FormData> forms;
   form_cache.ExtractNewForms(*web_frame, &forms);
   ASSERT_EQ(1U, forms.size());
 
-  // Set the auto-filled attribute on the firstname element.
+  // Set the auto-filled attribute.
   WebInputElement firstname =
       web_frame->document().getElementById("firstname").to<WebInputElement>();
   firstname.setAutofilled(true);
 
+  WebInputElement lastname =
+      web_frame->document().getElementById("lastname").to<WebInputElement>();
+  lastname.setAutofilled(true);
+
+  WebInputElement state =
+      web_frame->document().getElementById("state").to<WebInputElement>();
+  state.setAutofilled(true);
+
   // Set the value of the select-one.
   WebSelectElement select_element =
       web_frame->document().getElementById("state").to<WebSelectElement>();
   select_element.setValue(WebString::fromUTF8("AK"));
 
   // Clear the form.
   EXPECT_TRUE(form_cache.ClearFormWithElement(firstname));
 
   // Verify that the auto-filled attribute has been turned off.
   EXPECT_FALSE(firstname.isAutofilled());
@@ skipping 233 matching lines @@
   EXPECT_TRUE(email.suggestedValue().isEmpty());
   EXPECT_FALSE(email.isAutofilled());
   EXPECT_TRUE(email2.value().isEmpty());
   EXPECT_TRUE(email2.suggestedValue().isEmpty());
   EXPECT_FALSE(email2.isAutofilled());
   EXPECT_TRUE(phone.value().isEmpty());
   EXPECT_TRUE(phone.suggestedValue().isEmpty());
   EXPECT_FALSE(phone.isAutofilled());
 }
 
+// Autofill's "Clear Form" should clear only autofilled fields
+TEST_F(FormAutofillTest, ClearOnlyAutofilledFields) {
+  // Load the form.
+  LoadHTML(
+      "<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
+      "  <INPUT type=\"text\" id=\"firstname\" value=\"Wyatt\"/>"
+      "  <INPUT type=\"text\" id=\"lastname\" value=\"Earp\"/>"
+      "  <INPUT type=\"email\" id=\"email\" value=\"wyatt@earp.com\"/>"
+      "  <INPUT type=\"tel\" id=\"phone\" value=\"650-777-9999\"/>"
+      "  <INPUT type=\"submit\" value=\"Send\"/>"
+      "</FORM>");
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  FormCache form_cache;
+  std::vector<FormData> forms;
+  form_cache.ExtractNewForms(*web_frame, &forms);
+  ASSERT_EQ(1U, forms.size());
+
+  // Set the autofilled attribute.
+  WebInputElement firstname =
+      web_frame->document().getElementById("firstname").to<WebInputElement>();
+  firstname.setAutofilled(false);
+  WebInputElement lastname =
+      web_frame->document().getElementById("lastname").to<WebInputElement>();
+  lastname.setAutofilled(true);
+  WebInputElement email =
+      web_frame->document().getElementById("email").to<WebInputElement>();
+  email.setAutofilled(true);
+  WebInputElement phone =
+      web_frame->document().getElementById("phone").to<WebInputElement>();
+  phone.setAutofilled(true);
+
+  // Clear the fields.
+  EXPECT_TRUE(form_cache.ClearFormWithElement(firstname));
+
+  // Verify only autofilled fields are cleared.
+  EXPECT_EQ(ASCIIToUTF16("Wyatt"), firstname.value());
+  EXPECT_TRUE(firstname.suggestedValue().isEmpty());
+  EXPECT_FALSE(firstname.isAutofilled());
+  EXPECT_TRUE(lastname.value().isEmpty());
+  EXPECT_TRUE(lastname.suggestedValue().isEmpty());
+  EXPECT_FALSE(lastname.isAutofilled());
+  EXPECT_TRUE(email.value().isEmpty());
+  EXPECT_TRUE(email.suggestedValue().isEmpty());
+  EXPECT_FALSE(email.isAutofilled());
+  EXPECT_TRUE(phone.value().isEmpty());
+  EXPECT_TRUE(phone.suggestedValue().isEmpty());
+  EXPECT_FALSE(phone.isAutofilled());
+}
+
 TEST_F(FormAutofillTest, FormWithNodeIsAutofilled) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"Wyatt\"/>"
            "  <INPUT type=\"text\" id=\"lastname\"/>"
            "  <INPUT type=\"text\" id=\"email\"/>"
            "  <INPUT type=\"email\" id=\"email2\"/>"
            "  <INPUT type=\"tel\" id=\"phone\"/>"
            "  <INPUT type=\"submit\" value=\"Send\"/>"
            "</FORM>");
 
@@ skipping 159 matching lines @@
   expected.form_control_type = "text";
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("country");
   expected.value = ASCIIToUTF16("AL");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
-
 }  // namespace autofill