Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 316823003: GeolocationController should use HeapVector instead of PersistentHeapVector (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Visibility:
Public.

Description

GeolocationController should use HeapVector instead of PersistentHeapVector This is a follow-up fix after r175430. We don't need to use a PersistentHeapVector on a stack. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/modules/geolocation/GeolocationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
haraken
PTAL
6 years, 6 months ago (2014-06-04 09:44:46 UTC) #1
sof
lgtm
6 years, 6 months ago (2014-06-04 09:46:00 UTC) #2
Mads Ager (chromium)
LGTM, thanks.
6 years, 6 months ago (2014-06-04 09:50:08 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-06-04 10:18:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/316823003/1
6 years, 6 months ago (2014-06-04 10:19:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-04 11:20:28 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 13:00:59 UTC) #7
Message was sent while issue was closed.
Change committed as 175479

Powered by Google App Engine
This is Rietveld 408576698