Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: runtime/bin/eventhandler_win.h

Issue 316813006: Fix previous fix, by still making 'handle' the socket. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/eventhandler_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_win.h
diff --git a/runtime/bin/eventhandler_win.h b/runtime/bin/eventhandler_win.h
index 81d436fd482068b1c9cc76018e0e9abaad9619be..4bac8f4f29cc2d3b88c1951219da6ac478be0570 100644
--- a/runtime/bin/eventhandler_win.h
+++ b/runtime/bin/eventhandler_win.h
@@ -228,8 +228,7 @@ class Handle {
void Lock();
void Unlock();
- bool DoCreateCompletionPort(HANDLE handle, HANDLE completion_port);
- virtual bool CreateCompletionPort(HANDLE completion_port);
+ bool CreateCompletionPort(HANDLE completion_port);
void Close();
virtual void DoClose();
@@ -364,14 +363,12 @@ class SocketHandle : public Handle {
public:
SOCKET socket() const { return socket_; }
- virtual bool CreateCompletionPort(HANDLE completion_port);
-
protected:
explicit SocketHandle(SOCKET s)
- : Handle(INVALID_HANDLE_VALUE),
+ : Handle(reinterpret_cast<HANDLE>(s)),
socket_(s) {}
SocketHandle(SOCKET s, Dart_Port port)
- : Handle(INVALID_HANDLE_VALUE, port),
+ : Handle(reinterpret_cast<HANDLE>(s), port),
socket_(s) {}
virtual void HandleIssueError();
« no previous file with comments | « no previous file | runtime/bin/eventhandler_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698