Add non power of two gm for ETC1 bitmap

Add non power of two gm for ETC1 bitmap

Committed: https://skia.googlesource.com/skia/+/2dc337c3aeca0ba2a8dfc30cbdfd1d5e0bbef396

[robertphillips, 2014-06-04 14:36:50]

lgtm + some naming suggestions & questions

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp
File gm/etc1bitmap.cpp (right):

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode24
gm/etc1bitmap.cpp:24: // First, parse the data and get to it...
etc1data -> origData ?

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode29
gm/etc1bitmap.cpp:29: 
origW, origH ?

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode46
gm/etc1bitmap.cpp:46: 
Maybe amData -> newData ?

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode53
gm/etc1bitmap.cpp:53: for (int j = 0; j < blockHeight - 1; ++j) {
static const kETC1BlockBytes = 8; somewhere ?

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcod...
gm/etc1bitmap.cpp:161: virtual SkISize onISize() SK_OVERRIDE {
508 -> 124 ?

https://codereview.chromium.org/316813005/diff/40001/gm/etc1bitmap.cpp
File gm/etc1bitmap.cpp (right):

https://codereview.chromium.org/316813005/diff/40001/gm/etc1bitmap.cpp#newcode14
gm/etc1bitmap.cpp:14: 
Do we have to guard this for builds w/o etc1 ?

[krajcevski, 2014-06-04 14:52:17]

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp
File gm/etc1bitmap.cpp (right):

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode24
gm/etc1bitmap.cpp:24: // First, parse the data and get to it...
On 2014/06/04 14:36:50, robertphillips wrote:
> etc1data -> origData ?

Done.

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode29
gm/etc1bitmap.cpp:29: 
On 2014/06/04 14:36:50, robertphillips wrote:
> origW, origH ?

Done.

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode46
gm/etc1bitmap.cpp:46: 
On 2014/06/04 14:36:50, robertphillips wrote:
> Maybe amData -> newData ?

Done.

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcode53
gm/etc1bitmap.cpp:53: for (int j = 0; j < blockHeight - 1; ++j) {
On 2014/06/04 14:36:50, robertphillips wrote:
> static const kETC1BlockBytes = 8; somewhere ?

This is defined in etc1.h

https://codereview.chromium.org/316813005/diff/20001/gm/etc1bitmap.cpp#newcod...
gm/etc1bitmap.cpp:161: virtual SkISize onISize() SK_OVERRIDE {
On 2014/06/04 14:36:50, robertphillips wrote:
> 508 -> 124 ?

Done.

https://codereview.chromium.org/316813005/diff/40001/gm/etc1bitmap.cpp
File gm/etc1bitmap.cpp (right):

https://codereview.chromium.org/316813005/diff/40001/gm/etc1bitmap.cpp#newcode14
gm/etc1bitmap.cpp:14: 
On 2014/06/04 14:36:50, robertphillips wrote:
> Do we have to guard this for builds w/o etc1 ?

Well, I don't know if our gms go with our other source, but I'll put in the
guards anyway.

[krajcevski, 2014-06-04 16:45:17]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-06-04 16:46:09]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/316813005/120001

[commit-bot: I haz the power, 2014-06-04 16:57:51]

Change committed as 2dc337c3aeca0ba2a8dfc30cbdfd1d5e0bbef396