Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 316813003: DevTools: make Id the first parameter of protocol message. (Closed)

Created:
6 years, 6 months ago by loislo
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: make Id the first parameter of protocol message. It helps to troubleshoot messages traffic between DevTools and the inspected page. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/inspector/CodeGeneratorInspectorStrings.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/InspectorBackend.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
loislo
6 years, 6 months ago (2014-06-04 12:06:50 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-04 13:35:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/316813003/1
6 years, 6 months ago (2014-06-04 13:35:58 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 15:19:20 UTC) #4
Message was sent while issue was closed.
Change committed as 175491

Powered by Google App Engine
This is Rietveld 408576698