Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Issue 316813002: Start managed_mode refactor. (Closed)

Created:
6 years, 6 months ago by Marc Treib
Modified:
6 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Start managed_mode refactor. BUG=372381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276452

Patch Set 1 #

Total comments: 2

Patch Set 2 : update tests #

Patch Set 3 : fix non-themes build (android) #

Patch Set 4 : remove DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -71 lines) Patch
M chrome/browser/managed_mode/managed_user_service.h View 5 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 1 2 3 6 chunks +124 lines, -62 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_settings_service.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_settings_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_settings_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/supervised_user_pref_store_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Marc Treib
6 years, 6 months ago (2014-06-04 08:44:14 UTC) #1
Bernhard Bauer
I think some unit tests need to be updated as well. https://codereview.chromium.org/316813002/diff/1/chrome/browser/managed_mode/managed_user_settings_service.h File chrome/browser/managed_mode/managed_user_settings_service.h (right): ...
6 years, 6 months ago (2014-06-04 08:57:42 UTC) #2
Marc Treib
Tests updated! https://codereview.chromium.org/316813002/diff/1/chrome/browser/managed_mode/managed_user_settings_service.h File chrome/browser/managed_mode/managed_user_settings_service.h (right): https://codereview.chromium.org/316813002/diff/1/chrome/browser/managed_mode/managed_user_settings_service.h#newcode82 chrome/browser/managed_mode/managed_user_settings_service.h:82: // when itself is (de)activated. On 2014/06/04 ...
6 years, 6 months ago (2014-06-04 09:23:25 UTC) #3
Bernhard Bauer
LGTM once you get the Android build error fixed. FTR, you should be able to ...
6 years, 6 months ago (2014-06-04 11:18:44 UTC) #4
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-11 08:11:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/316813002/60001
6 years, 6 months ago (2014-06-11 08:13:12 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 18:09:30 UTC) #7
Message was sent while issue was closed.
Change committed as 276452

Powered by Google App Engine
This is Rietveld 408576698