Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 316803003: Add browser_tests.exe to list of files archived for Windows builds. (Closed)

Created:
6 years, 6 months ago by anandc
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add browser_tests.exe to list of files archived for Windows builds. This is following up from CL: https://codereview.chromium.org/302403003/ BUG=379986 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275105

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (0 generated)
anandc
https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES.cfg File chrome/tools/build/win/FILES.cfg (right): https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES.cfg#newcode35 chrome/tools/build/win/FILES.cfg:35: 'buildtype': ['dev', 'official'], Does buildtype='dev' mean Chromium? If so, ...
6 years, 6 months ago (2014-06-04 16:17:32 UTC) #1
Michael Moss
lgtm https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES.cfg File chrome/tools/build/win/FILES.cfg (right): https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES.cfg#newcode35 chrome/tools/build/win/FILES.cfg:35: 'buildtype': ['dev', 'official'], On 2014/06/04 16:17:33, anandc wrote: ...
6 years, 6 months ago (2014-06-04 16:44:19 UTC) #2
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-04 16:52:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/316803003/1
6 years, 6 months ago (2014-06-04 16:54:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 20:01:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 20:06:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10497)
6 years, 6 months ago (2014-06-04 20:06:55 UTC) #7
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-05 00:13:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/316803003/1
6 years, 6 months ago (2014-06-05 00:15:36 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 00:20:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 00:27:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10692)
6 years, 6 months ago (2014-06-05 00:27:22 UTC) #12
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-05 14:19:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/316803003/1
6 years, 6 months ago (2014-06-05 14:21:55 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 14:41:12 UTC) #15
Message was sent while issue was closed.
Change committed as 275105

Powered by Google App Engine
This is Rietveld 408576698