|
|
Created:
6 years, 6 months ago by anandc Modified:
6 years, 6 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd browser_tests.exe to list of files archived for Windows builds.
This is following up from CL: https://codereview.chromium.org/302403003/
BUG=379986
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275105
Patch Set 1 #
Total comments: 2
Messages
Total messages: 15 (0 generated)
https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES... File chrome/tools/build/win/FILES.cfg (right): https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES... chrome/tools/build/win/FILES.cfg:35: 'buildtype': ['dev', 'official'], Does buildtype='dev' mean Chromium? If so, then we'd like to get browser_tests.exe for those builds as well.
lgtm https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES... File chrome/tools/build/win/FILES.cfg (right): https://codereview.chromium.org/316803003/diff/1/chrome/tools/build/win/FILES... chrome/tools/build/win/FILES.cfg:35: 'buildtype': ['dev', 'official'], On 2014/06/04 16:17:33, anandc wrote: > Does buildtype='dev' mean Chromium? If so, then we'd like to get > browser_tests.exe for those builds as well. Yes, basically the chromium builders vs. the release builders.
The CQ bit was checked by anandc@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/316803003/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
The CQ bit was checked by anandc@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/316803003/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
The CQ bit was checked by anandc@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/316803003/1
Message was sent while issue was closed.
Change committed as 275105 |