Always read and write Google Update registry values from the 32-bit hive, even on 64-bit systems.

Always read and write Google Update registry values from the 32-bit hive, even on 64-bit systems.

BUG=380371
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274907

[Will Harris, 2014-06-04 05:40:56]

Fix a few missing Wow64 accesses.

[grt (UTC plus 2), 2014-06-04 17:20:04]

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
File chrome/installer/util/google_update_settings.cc (right):

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:98: RegKey
key(HKEY_CURRENT_USER, app_reg_data.GetStateKey().c_str(),
although you and i know that this isn't currently affected by WoW, it may be
hard for readers to see that this is obviously true. since the WOW64_32 flag is
applied elsewhere regardless of HKLM vs. HKCU, would you mind doing that here as
well? it may simplify things to put a:
  const REGSAM kAccess = KEY_SET_VALUE | KEY_WOW64_32KEY;
at the top of the function and use it in both places.

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:235: KEY_QUERY_VALUE |
KEY_WOW64_32KEY) == ERROR_SUCCESS &&
i like
  const REGSAM kAccess = KEY_QUERY_VALUE | KEY_WOW64_32KEY;
for use here and below, too.

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:315: KEY_SET_VALUE |
KEY_WOW64_32KEY) != ERROR_SUCCESS ||
local const for this function, too?

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:703: KEY_QUERY_VALUE) ==
ERROR_SUCCESS) {
 | KEY_WOW64_32KEY

[Will Harris, 2014-06-04 17:48:07]

PTAL. Thanks.

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
File chrome/installer/util/google_update_settings.cc (right):

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:98: RegKey
key(HKEY_CURRENT_USER, app_reg_data.GetStateKey().c_str(),
On 2014/06/04 17:20:05, grt wrote:
> although you and i know that this isn't currently affected by WoW, it may be
> hard for readers to see that this is obviously true. since the WOW64_32 flag
is
> applied elsewhere regardless of HKLM vs. HKCU, would you mind doing that here
as
> well? it may simplify things to put a:
>   const REGSAM kAccess = KEY_SET_VALUE | KEY_WOW64_32KEY;
> at the top of the function and use it in both places.

Done.

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:235: KEY_QUERY_VALUE |
KEY_WOW64_32KEY) == ERROR_SUCCESS &&
On 2014/06/04 17:20:05, grt wrote:
> i like
>   const REGSAM kAccess = KEY_QUERY_VALUE | KEY_WOW64_32KEY;
> for use here and below, too.

Done.

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:315: KEY_SET_VALUE |
KEY_WOW64_32KEY) != ERROR_SUCCESS ||
On 2014/06/04 17:20:05, grt wrote:
> local const for this function, too?

Done.

https://codereview.chromium.org/316753003/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:703: KEY_QUERY_VALUE) ==
ERROR_SUCCESS) {
On 2014/06/04 17:20:05, grt wrote:
>  | KEY_WOW64_32KEY

Good spot.  Done.

[grt (UTC plus 2), 2014-06-04 18:21:35]

lgtm

[commit-bot: I haz the power, 2014-06-04 18:23:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wfh@chromium.org/316753003/20001

[commit-bot: I haz the power, 2014-06-04 21:13:59]

Change committed as 274907