Issue 316733004: MouseEvent.offsetX/Y should just return 0,0 for simulated clicks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316733004: MouseEvent.offsetX/Y should just return 0,0 for simulated clicks. (Closed)

Created:
6 years, 6 months ago by abarth-chromium

Modified:
6 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews, dglazkov, eseidel, esprehn, ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

MouseEvent.offsetX/Y should just return 0,0 for simulated clicks. There's no need to compute the exact target-relative coordinates for simulated mouse events, e.g those fired by HTMLElement.click(). The offsetX/Y properties are not supported by Firefox. This CL merges http://trac.webkit.org/changeset/164871/ by kling, which made WebKit go fast on Speedometer. BUG=380173 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175426

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -0 lines)			Patch
A	LayoutTests/fast/events/relative-offset-of-simulated-click.html	View	1 chunk	+48 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/events/relative-offset-of-simulated-click-expected.txt	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/core/events/MouseRelatedEvent.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/316733004/1

6 years, 6 months ago (2014-06-04 00:18:12 UTC) #3

Message was sent while issue was closed.

Change committed as 175426

Expand Messages | Collapse Messages