Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 316713002: Wire input events through the ViewManagerClient interface. (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Wire input events through the ViewManagerClient interface. This is the patch at https://codereview.chromium.org/300863003/ updated for trunk with some gyp tweaks. BUG=365012 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274929

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : fix windows #

Patch Set 4 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -31 lines) Patch
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/examples/sample_view_manager_app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/sample_view_manager_app/sample_view_manager_app.cc View 3 chunks +48 lines, -1 line 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 5 chunks +28 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 5 chunks +9 lines, -28 lines 0 comments Download
A + mojo/services/public/cpp/input_events/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A mojo/services/public/cpp/input_events/input_events_type_converters.h View 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/input_events/mojo_input_events_export.h View 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/view_manager/node.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/node.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/node_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 3 chunks +16 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
sky
6 years, 6 months ago (2014-06-03 19:52:48 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/316713002/diff/20001/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc File mojo/examples/sample_view_manager_app/sample_view_manager_app.cc (right): https://codereview.chromium.org/316713002/diff/20001/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc#newcode24 mojo/examples/sample_view_manager_app/sample_view_manager_app.cc:24: std::string EventNameForAction(int32_t action) { it might be better ...
6 years, 6 months ago (2014-06-03 19:58:07 UTC) #2
sky
https://codereview.chromium.org/316713002/diff/20001/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc File mojo/examples/sample_view_manager_app/sample_view_manager_app.cc (right): https://codereview.chromium.org/316713002/diff/20001/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc#newcode24 mojo/examples/sample_view_manager_app/sample_view_manager_app.cc:24: std::string EventNameForAction(int32_t action) { On 2014/06/03 19:58:06, Ben Goodger ...
6 years, 6 months ago (2014-06-03 20:00:03 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-03 20:00:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/316713002/20001
6 years, 6 months ago (2014-06-03 20:01:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 00:46:14 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 00:52:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/148476)
6 years, 6 months ago (2014-06-04 00:52:42 UTC) #8
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-04 16:03:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/316713002/20001
6 years, 6 months ago (2014-06-04 16:04:00 UTC) #10
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-04 16:31:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/316713002/40001
6 years, 6 months ago (2014-06-04 16:32:39 UTC) #12
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-04 18:11:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/316713002/60001
6 years, 6 months ago (2014-06-04 18:13:40 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 22:07:41 UTC) #15
sky
Committed patchset #4 manually as r274929 (presubmit successful).
6 years, 6 months ago (2014-06-04 22:15:55 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 22:16:12 UTC) #17
Message was sent while issue was closed.
Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

Powered by Google App Engine
This is Rietveld 408576698