Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 3167027: Merge 56737 - Fix numerous alignment problems, both horizontal and vertical, ... (Closed)

Created:
10 years, 4 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 56737 - Fix numerous alignment problems, both horizontal and vertical, in drawing the browser chrome. This doesn't fix problems with the NTP background image offsets (see bug 51853). This also makes sure the OTR avatar is reversed in RTL mode, and clipped as usefully as possible when there isn't enough room for the full image. BUG=44157 TEST=Frame, toolbar, bookmark bar, and find bar all look lined up with default and custom themes, restored and maximized, LTR and RTL, side tabs and normal tabs, and in popup and app windows Review URL: http://codereview.chromium.org/3137019 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -357 lines) Patch
M chrome/browser/chromeos/frame/normal_browser_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/frame/normal_browser_frame_view.cc View 4 chunks +21 lines, -14 lines 0 comments Download
M chrome/browser/views/detachable_toolbar_view.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/views/detachable_toolbar_view.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/views/dropdown_bar_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/views/dropdown_bar_host.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/views/find_bar_view.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/views/frame/app_panel_browser_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/frame/app_panel_browser_frame_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_frame.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/views/frame/browser_frame_gtk.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/frame/browser_frame_gtk.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_win.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_win.cc View 3 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/views/frame/browser_non_client_frame_view.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.h View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 4 chunks +25 lines, -7 lines 0 comments Download
M chrome/browser/views/frame/browser_view_layout.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.cc View 12 chunks +91 lines, -86 lines 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.h View 6 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 23 chunks +141 lines, -171 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Peter Kasting
10 years, 4 months ago (2010-08-19 21:11:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698