Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/speech/speech_input_manager.h

Issue 3167011: Revert 56006 - Revert 56002 - Adds SpeechInputManagerImpl to handle requests ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/speech/speech_input_dispatcher_host.h ('k') | chrome/browser/speech/speech_input_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/speech/speech_input_manager.h
===================================================================
--- chrome/browser/speech/speech_input_manager.h (revision 56006)
+++ chrome/browser/speech/speech_input_manager.h (working copy)
@@ -18,7 +18,7 @@
class SpeechInputManager {
public:
// Implemented by the dispatcher host to relay events to the render views.
- class Listener {
+ class Delegate {
public:
virtual void SetRecognitionResult(int render_view_id,
const string16& value) = 0;
@@ -27,9 +27,9 @@
};
// Factory method to create new instances.
- static SpeechInputManager* Create(Listener* listener);
+ static SpeechInputManager* Create(Delegate* delegate);
// Factory method definition useful for tests.
- typedef SpeechInputManager* (FactoryMethod)(Listener*);
+ typedef SpeechInputManager* (FactoryMethod)(Delegate*);
virtual ~SpeechInputManager() {}
@@ -39,6 +39,12 @@
virtual void StopRecording(int render_view_id) = 0;
};
+// This typedef is to workaround the issue with certain versions of
+// Visual Studio where it gets confused between multiple Delegate
+// classes and gives a C2500 error. (I saw this error on the try bots -
+// the workaround was not needed for my machine).
+typedef SpeechInputManager::Delegate SpeechInputManagerDelegate;
+
} // namespace speech_input
#endif // CHROME_BROWSER_SPEECH_SPEECH_INPUT_MANAGER_H_
« no previous file with comments | « chrome/browser/speech/speech_input_dispatcher_host.h ('k') | chrome/browser/speech/speech_input_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698