Issue 3167011: Revert 56006 - Revert 56002 - Adds SpeechInputManagerImpl to handle requests ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3167011: Revert 56006 - Revert 56002 - Adds SpeechInputManagerImpl to handle requests ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by satorux1

Modified:
4 years ago

Reviewers:
satorux1

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 56006 - Revert 56002 - Adds SpeechInputManagerImpl to handle requests from render views and return recognition events. Confirmed that r56002 was not guilty. This CL depends on http://codereview.chromium.org/3124009 going in first for the SpeechRecognizer class. Also renamed SpeechInputManager::Listener to Delegate to be consistent with Chromium terminology. TEST=manually, open a webpage containing an <input speech> tag and click on the speech button to test. BUG=none Review URL: http://codereview.chromium.org/3108007 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/3184001 TBR=satorux@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56007

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -16 lines)			Patch
M	chrome/browser/speech/speech_input_browsertest.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/speech/speech_input_dispatcher_host.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.h	View	3 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.cc	View	1 chunk	+88 lines, -3 lines	0 comments	Download

Trybot results:

Total messages: 1 (0 generated)