Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 316693003: Remove scheduleLayerUpdate from RenderLayerCompositor. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Remove scheduleLayerUpdate from RenderLayerCompositor. NOT FOR COMMIT. This is just to run on the trybots. Now that frames always have a layer and get their self-painting bit updated whenever m_compositing changes, we don't need to do a layer update when they get composited. Instead we just need to mark the frame in the owner page as needing a compositing update. This removes one of the needs for applyUpdateLayerCompositingStateChickenEggHacks.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3151 lines, -2889 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +50 lines, -3 lines 0 comments Download
M LayoutTests/compositing/framesets/composited-frame-alignment-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M LayoutTests/fast/block/float/4145535Crash-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/frames/002-expected.txt View 1 chunk +21 lines, -18 lines 0 comments Download
M LayoutTests/fast/frames/calculate-fixed-expected.txt View 1 chunk +224 lines, -222 lines 0 comments Download
M LayoutTests/fast/frames/calculate-order-expected.txt View 1 chunk +77 lines, -96 lines 0 comments Download
M LayoutTests/fast/frames/calculate-percentage-expected.txt View 1 chunk +140 lines, -138 lines 0 comments Download
M LayoutTests/fast/frames/calculate-relative-expected.txt View 1 chunk +119 lines, -114 lines 0 comments Download
M LayoutTests/fast/frames/calculate-round-expected.txt View 1 chunk +476 lines, -408 lines 0 comments Download
M LayoutTests/fast/frames/empty-cols-attribute-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/empty-frame-src-expected.txt View 1 chunk +21 lines, -18 lines 0 comments Download
M LayoutTests/fast/frames/frame-length-fractional-expected.txt View 1 chunk +56 lines, -48 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-rotation-hit-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-3d-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-centered-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-hit-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-rotate-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-skew-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/frames/invalid-expected.txt View 1 chunk +217 lines, -186 lines 0 comments Download
M LayoutTests/fast/frames/no-frame-borders-expected.txt View 1 chunk +21 lines, -18 lines 0 comments Download
M LayoutTests/fast/frames/valid-expected.txt View 1 chunk +217 lines, -186 lines 0 comments Download
M LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-001-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-002-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-003-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-004-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-005-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt View 1 chunk +40 lines, -35 lines 0 comments Download
M LayoutTests/platform/linux/editing/pasteboard/pasting-object-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/block/basic/013-expected.txt View 2 chunks +13 lines, -12 lines 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt View 1 chunk +19 lines, -17 lines 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/frames/001-expected.txt View 2 chunks +14 lines, -12 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frame-navigation-expected.txt View 1 chunk +23 lines, -21 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frame-scrolling-attribute-expected.txt View 1 chunk +104 lines, -96 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frameElement-frame-expected.txt View 1 chunk +10 lines, -9 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frameset-style-recalc-expected.txt View 1 chunk +33 lines, -31 lines 0 comments Download
M LayoutTests/platform/linux/fast/loader/text-document-wrapping-expected.txt View 1 chunk +16 lines, -15 lines 0 comments Download
M LayoutTests/platform/linux/fast/parser/001-expected.txt View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/replaced/007-expected.txt View 2 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/fast/replaced/border-radius-clip-expected.txt View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/replaced/replaced-breaking-expected.txt View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt View 1 chunk +40 lines, -35 lines 0 comments Download
M LayoutTests/platform/linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt View 1 chunk +8 lines, -7 lines 0 comments Download
M LayoutTests/platform/linux/svg/as-image/img-preserveAspectRatio-support-1-expected.txt View 8 chunks +70 lines, -62 lines 0 comments Download
M LayoutTests/platform/linux/svg/as-image/img-preserveAspectRatio-support-2-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/svg/as-object/object-box-sizing-no-width-height-expected.txt View 1 chunk +28 lines, -24 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/embedding-external-svgs-expected.txt View 2 chunks +45 lines, -44 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/getsvgdocument-expected.txt View 1 chunk +20 lines, -18 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/object-no-size-attributes-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/object-sizing-expected.txt View 2 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/object-sizing-explicit-height-expected.txt View 1 chunk +64 lines, -56 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/object-sizing-explicit-width-expected.txt View 1 chunk +64 lines, -56 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/object-sizing-explicit-width-height-expected.txt View 1 chunk +32 lines, -28 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/object-sizing-no-width-height-expected.txt View 1 chunk +8 lines, -7 lines 0 comments Download
M LayoutTests/platform/linux/svg/hixie/intrinsic/003-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/platform/linux/svg/hixie/text/003-expected.txt View 1 chunk +18 lines, -16 lines 0 comments Download
M LayoutTests/platform/linux/svg/in-html/by-reference-expected.txt View 1 chunk +24 lines, -20 lines 0 comments Download
M LayoutTests/platform/linux/svg/wicd/rightsizing-grid-expected.txt View 2 chunks +265 lines, -248 lines 0 comments Download
M LayoutTests/platform/linux/svg/wicd/sizing-flakiness-expected.txt View 1 chunk +14 lines, -13 lines 0 comments Download
M LayoutTests/platform/linux/svg/wicd/test-rightsizing-a-expected.txt View 3 chunks +26 lines, -24 lines 0 comments Download
M LayoutTests/platform/linux/svg/wicd/test-rightsizing-b-expected.txt View 2 chunks +52 lines, -48 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt View 8 chunks +70 lines, -62 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt View 1 chunk +40 lines, -35 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt View 1 chunk +19 lines, -18 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt View 1 chunk +19 lines, -18 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt View 2 chunks +35 lines, -34 lines 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt View 1 chunk +19 lines, -18 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-object-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.h View 1 chunk +0 lines, -26 lines 0 comments Download
D Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderIFrame.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderPart.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 5 chunks +14 lines, -35 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698