Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 316663003: Remove multipart_browsertest.cc (Closed)

Created:
6 years, 6 months ago by Nate Chapin
Modified:
6 years, 6 months ago
Reviewers:
sky, Paweł Hajdan Jr.
CC:
chromium-reviews, cbentzel+watch_chromium.org, browser-components-watch_chromium.org
Visibility:
Public.

Description

Remove multipart_browsertest.cc Its only case has been disabled for a couple years, and blink has since removed the feature it was testing (multipart main reosurces). BUG=136310 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -71 lines) Patch
D chrome/browser/history/multipart_browsertest.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/testserver/testserver.py View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nate Chapin
Pawel: please review the net/tools/testserver/ change sky: please review the chrome/ change
6 years, 6 months ago (2014-06-03 22:39:35 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-03 23:10:10 UTC) #2
Paweł Hajdan Jr.
LGTM
6 years, 6 months ago (2014-06-04 10:36:55 UTC) #3
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 6 months ago (2014-06-04 16:39:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/316663003/1
6 years, 6 months ago (2014-06-04 16:43:04 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 19:58:04 UTC) #6
Message was sent while issue was closed.
Change committed as 274889

Powered by Google App Engine
This is Rietveld 408576698