use non-deprecated version of installPixel() that takes colortable

use non-deprecated version of installPixel() that takes colortable

NOTRY=True
only failing/retrying bot is android, and this change is explicitly only for windows.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274651

[f(malita), 2014-06-03 17:57:59]

lgtm

https://codereview.chromium.org/316663002/diff/1/skia/ext/bitmap_platform_dev...
File skia/ext/bitmap_platform_device_win.cc (right):

https://codereview.chromium.org/316663002/diff/1/skia/ext/bitmap_platform_dev...
skia/ext/bitmap_platform_device_win.cc:111: return bitmap->installPixels(info,
data, rowBytes, color_table,
Pass NULL directly?

[reed1, 2014-06-03 17:59:47]

On 2014/06/03 17:57:59, Florin Malita wrote:
> lgtm
> 
>
https://codereview.chromium.org/316663002/diff/1/skia/ext/bitmap_platform_dev...
> File skia/ext/bitmap_platform_device_win.cc (right):
> 
>
https://codereview.chromium.org/316663002/diff/1/skia/ext/bitmap_platform_dev...
> skia/ext/bitmap_platform_device_win.cc:111: return bitmap->installPixels(info,
> data, rowBytes, color_table,
> Pass NULL directly?

Is that clearer? I have seen this pattern somewhere else, where we document what
the NULL or the true/false mean.

[f(malita), 2014-06-03 18:05:03]

On 2014/06/03 17:59:47, reed1 wrote:
> On 2014/06/03 17:57:59, Florin Malita wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/316663002/diff/1/skia/ext/bitmap_platform_dev...
> > File skia/ext/bitmap_platform_device_win.cc (right):
> > 
> >
>
https://codereview.chromium.org/316663002/diff/1/skia/ext/bitmap_platform_dev...
> > skia/ext/bitmap_platform_device_win.cc:111: return
bitmap->installPixels(info,
> > data, rowBytes, color_table,
> > Pass NULL directly?
> 
> Is that clearer? I have seen this pattern somewhere else, where we document
what
> the NULL or the true/false mean.

Ah, possible. I've seen inline comments being used for that purpose (data,
rowBytes, NULL /* colorTable */, DeleteHBitmapCallback, ...), but I don't have a
strong opinion. Feel free to leave as is.

[reed1, 2014-06-03 18:29:30]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-06-03 18:30:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reed@google.com/316663002/20001

[reed1, 2014-06-03 22:22:10]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-06-03 22:22:25]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-06-03 22:23:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reed@google.com/316663002/20001

[commit-bot: I haz the power, 2014-06-03 22:25:06]

Change committed as 274651