ChildProcessSecurityPolicy: Add DeleteFromFileSystem permission.

content/browser/child_process_security_policy_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/platform_file.h"
@@ skipping 71 matching lines @@
     test_browser_client_.AddScheme(scheme);
   }
 
   void GrantPermissionsForFile(ChildProcessSecurityPolicyImpl* p,
                                int child_id,
                                const base::FilePath& file,
                                int permissions) {
     p->GrantPermissionsForFile(child_id, file, permissions);
   }
 
+  void CheckHasNoFileSystemPermission(ChildProcessSecurityPolicyImpl* p,
+                                      const std::string& child_id) {
+    EXPECT_FALSE(p->CanReadFileSystem(kRendererID, child_id));
+    EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, child_id));
+    EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, child_id));
+    EXPECT_FALSE(p->CanDeleteFromFileSystem(kRendererID, child_id));
+  }
+
+  void CheckHasNoFileSystemFilePermission(ChildProcessSecurityPolicyImpl* p,
+                                          const base::FilePath& file,
+                                          const fileapi::FileSystemURL& url) {
+    EXPECT_FALSE(p->CanReadFile(kRendererID, file));
+    EXPECT_FALSE(p->CanCreateReadWriteFile(kRendererID, file));
+    EXPECT_FALSE(p->CanReadFileSystemFile(kRendererID, url));
+    EXPECT_FALSE(p->CanWriteFileSystemFile(kRendererID, url));
+    EXPECT_FALSE(p->CanCreateFileSystemFile(kRendererID, url));
+    EXPECT_FALSE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+    EXPECT_FALSE(p->CanCopyIntoFileSystemFile(kRendererID, url));
+    EXPECT_FALSE(p->CanDeleteFileSystemFile(kRendererID, url));
+  }
+
  private:
   ChildProcessSecurityPolicyTestBrowserClient test_browser_client_;
   ContentBrowserClient* old_browser_client_;
 };
 
 
 TEST_F(ChildProcessSecurityPolicyTest, IsWebSafeSchemeTest) {
   ChildProcessSecurityPolicyImpl* p =
       ChildProcessSecurityPolicyImpl::GetInstance();
 
@@ skipping 191 matching lines @@
                                        "read_filesystem",
                                        base::FilePath());
   std::string read_write_id = fileapi::IsolatedContext::GetInstance()->
       RegisterFileSystemForVirtualPath(fileapi::kFileSystemTypeTest,
                                        "read_write_filesystem",
                                        base::FilePath());
   std::string copy_into_id = fileapi::IsolatedContext::GetInstance()->
       RegisterFileSystemForVirtualPath(fileapi::kFileSystemTypeTest,
                                        "copy_into_filesystem",
                                        base::FilePath());
+  std::string delete_from_id = fileapi::IsolatedContext::GetInstance()->
+      RegisterFileSystemForVirtualPath(fileapi::kFileSystemTypeTest,
+                                       "delete_from_filesystem",
+                                       base::FilePath());
 
   // Test initially having no permissions.
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, read_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, read_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_id));
-
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, read_write_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, read_write_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_write_id));
-
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, copy_into_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, copy_into_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, copy_into_id));
+  CheckHasNoFileSystemPermission(p, read_id);
+  CheckHasNoFileSystemPermission(p, read_write_id);
+  CheckHasNoFileSystemPermission(p, copy_into_id);
+  CheckHasNoFileSystemPermission(p, delete_from_id);
 
   // Testing varying combinations of grants and checks.
   p->GrantReadFileSystem(kRendererID, read_id);
   EXPECT_TRUE(p->CanReadFileSystem(kRendererID, read_id));
   EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, read_id));
   EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_id));
+  EXPECT_FALSE(p->CanDeleteFromFileSystem(kRendererID, read_id));
 
   p->GrantReadFileSystem(kRendererID, read_write_id);
   p->GrantWriteFileSystem(kRendererID, read_write_id);
   EXPECT_TRUE(p->CanReadFileSystem(kRendererID, read_write_id));
   EXPECT_TRUE(p->CanReadWriteFileSystem(kRendererID, read_write_id));
   EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_write_id));
+  EXPECT_FALSE(p->CanDeleteFromFileSystem(kRendererID, read_write_id));
 
   p->GrantCopyIntoFileSystem(kRendererID, copy_into_id);
   EXPECT_FALSE(p->CanReadFileSystem(kRendererID, copy_into_id));
   EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, copy_into_id));
   EXPECT_TRUE(p->CanCopyIntoFileSystem(kRendererID, copy_into_id));
+  EXPECT_FALSE(p->CanDeleteFromFileSystem(kRendererID, copy_into_id));
+
+  p->GrantDeleteFromFileSystem(kRendererID, delete_from_id);
+  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, delete_from_id));
+  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, delete_from_id));
+  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, delete_from_id));
+  EXPECT_TRUE(p->CanDeleteFromFileSystem(kRendererID, delete_from_id));
 
   // Test revoke permissions on renderer ID removal.
   p->Remove(kRendererID);
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, read_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, read_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_id));
-
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, read_write_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, read_write_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_write_id));
-
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, copy_into_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, copy_into_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, copy_into_id));
+  CheckHasNoFileSystemPermission(p, read_id);
+  CheckHasNoFileSystemPermission(p, read_write_id);
+  CheckHasNoFileSystemPermission(p, copy_into_id);
+  CheckHasNoFileSystemPermission(p, delete_from_id);
 
   // Test having no permissions upon re-adding same renderer ID.
   p->Add(kRendererID);
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, read_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, read_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_id));
-
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, read_write_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, read_write_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, read_write_id));
-
-  EXPECT_FALSE(p->CanReadFileSystem(kRendererID, copy_into_id));
-  EXPECT_FALSE(p->CanReadWriteFileSystem(kRendererID, copy_into_id));
-  EXPECT_FALSE(p->CanCopyIntoFileSystem(kRendererID, copy_into_id));
+  CheckHasNoFileSystemPermission(p, read_id);
+  CheckHasNoFileSystemPermission(p, read_write_id);
+  CheckHasNoFileSystemPermission(p, copy_into_id);
+  CheckHasNoFileSystemPermission(p, delete_from_id);
 
   // Cleanup.
   p->Remove(kRendererID);
   fileapi::IsolatedContext::GetInstance()->RevokeFileSystem(read_id);
   fileapi::IsolatedContext::GetInstance()->RevokeFileSystem(read_write_id);
   fileapi::IsolatedContext::GetInstance()->RevokeFileSystem(copy_into_id);
+  fileapi::IsolatedContext::GetInstance()->RevokeFileSystem(delete_from_id);
 }
 
 TEST_F(ChildProcessSecurityPolicyTest, FilePermissionGrantingAndRevoking) {
   ChildProcessSecurityPolicyImpl* p =
       ChildProcessSecurityPolicyImpl::GetInstance();
 
   p->RegisterFileSystemPermissionPolicy(
       fileapi::kFileSystemTypeTest,
       fileapi::FILE_PERMISSION_USE_FILE_PERMISSION);
 
   p->Add(kRendererID);
   base::FilePath file(TEST_PATH("/dir/testfile"));
   file = file.NormalizePathSeparators();
   fileapi::FileSystemURL url = fileapi::FileSystemURL::CreateForTest(
       GURL("http://foo/"), fileapi::kFileSystemTypeTest, file);
 
   // Test initially having no permissions.
-  EXPECT_FALSE(p->CanReadFile(kRendererID, file));
-  EXPECT_FALSE(p->CanCreateReadWriteFile(kRendererID, file));
-  EXPECT_FALSE(p->CanReadFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanWriteFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  CheckHasNoFileSystemFilePermission(p, file, url);
 
   // Testing every combination of permissions granting and revoking.
   p->GrantReadFile(kRendererID, file);
   EXPECT_TRUE(p->CanReadFile(kRendererID, file));
   EXPECT_FALSE(p->CanCreateReadWriteFile(kRendererID, file));
   EXPECT_TRUE(p->CanReadFileSystemFile(kRendererID, url));
   EXPECT_FALSE(p->CanWriteFileSystemFile(kRendererID, url));
   EXPECT_FALSE(p->CanCreateFileSystemFile(kRendererID, url));
   EXPECT_FALSE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  EXPECT_FALSE(p->CanCopyIntoFileSystemFile(kRendererID, url));
+  EXPECT_FALSE(p->CanDeleteFileSystemFile(kRendererID, url));
   p->RevokeAllPermissionsForFile(kRendererID, file);
-  EXPECT_FALSE(p->CanReadFile(kRendererID, file));
-  EXPECT_FALSE(p->CanCreateReadWriteFile(kRendererID, file));
-  EXPECT_FALSE(p->CanReadFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanWriteFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  CheckHasNoFileSystemFilePermission(p, file, url);
 
   p->GrantCreateReadWriteFile(kRendererID, file);
   EXPECT_TRUE(p->CanReadFile(kRendererID, file));
   EXPECT_TRUE(p->CanCreateReadWriteFile(kRendererID, file));
   EXPECT_TRUE(p->CanReadFileSystemFile(kRendererID, url));
   EXPECT_TRUE(p->CanWriteFileSystemFile(kRendererID, url));
   EXPECT_TRUE(p->CanCreateFileSystemFile(kRendererID, url));
   EXPECT_TRUE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  EXPECT_TRUE(p->CanCopyIntoFileSystemFile(kRendererID, url));
+  EXPECT_TRUE(p->CanDeleteFileSystemFile(kRendererID, url));
   p->RevokeAllPermissionsForFile(kRendererID, file);
-  EXPECT_FALSE(p->CanReadFile(kRendererID, file));
-  EXPECT_FALSE(p->CanCreateReadWriteFile(kRendererID, file));
-  EXPECT_FALSE(p->CanReadFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanWriteFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  CheckHasNoFileSystemFilePermission(p, file, url);
 
   // Test revoke permissions on renderer ID removal.
   p->GrantCreateReadWriteFile(kRendererID, file);
   EXPECT_TRUE(p->CanReadFile(kRendererID, file));
   EXPECT_TRUE(p->CanCreateReadWriteFile(kRendererID, file));
   EXPECT_TRUE(p->CanReadFileSystemFile(kRendererID, url));
   EXPECT_TRUE(p->CanWriteFileSystemFile(kRendererID, url));
   EXPECT_TRUE(p->CanCreateFileSystemFile(kRendererID, url));
   EXPECT_TRUE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  EXPECT_TRUE(p->CanCopyIntoFileSystemFile(kRendererID, url));
+  EXPECT_TRUE(p->CanDeleteFileSystemFile(kRendererID, url));
   p->Remove(kRendererID);
-  EXPECT_FALSE(p->CanReadFile(kRendererID, file));
-  EXPECT_FALSE(p->CanCreateReadWriteFile(kRendererID, file));
-  EXPECT_FALSE(p->CanReadFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanWriteFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  CheckHasNoFileSystemFilePermission(p, file, url);
 
   // Test having no permissions upon re-adding same renderer ID.
   p->Add(kRendererID);
-  EXPECT_FALSE(p->CanReadFile(kRendererID, file));
-  EXPECT_FALSE(p->CanCreateReadWriteFile(kRendererID, file));
-  EXPECT_FALSE(p->CanReadFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanWriteFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateFileSystemFile(kRendererID, url));
-  EXPECT_FALSE(p->CanCreateReadWriteFileSystemFile(kRendererID, url));
+  CheckHasNoFileSystemFilePermission(p, file, url);
 
   // Cleanup.
   p->Remove(kRendererID);
 }
 
 TEST_F(ChildProcessSecurityPolicyTest, FilePermissions) {
   base::FilePath granted_file = base::FilePath(TEST_PATH("/home/joe"));
   base::FilePath sibling_file = base::FilePath(TEST_PATH("/home/bob"));
   base::FilePath child_file = base::FilePath(TEST_PATH("/home/joe/file"));
   base::FilePath parent_file = base::FilePath(TEST_PATH("/home"));
@@ skipping 183 matching lines @@
   // queried on the IO thread.  The ChildProcessSecurityPolicy needs to be
   // prepared to answer policy questions about renderers who no longer exist.
 
   // In this case, we default to secure behavior.
   EXPECT_FALSE(p->CanRequestURL(kRendererID, url));
   EXPECT_FALSE(p->CanReadFile(kRendererID, file));
   EXPECT_FALSE(p->HasWebUIBindings(kRendererID));
 }
 
 }  // namespace content