Cleanly return VERIFY_FAILED if no suitable X509TrustManager is found.

Cleanly return VERIFY_FAILED if no suitable X509TrustManager is found.

Certificate verification still won't be functional and VERIFY_FAILED will
NOTREACHED() on a debug build, but this is probably better-behaved than a
NullPointerException, and we try to handle other initialization failures.

BUG=376660
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274595

[davidben, 2014-06-03 17:07:28]

This is probably worthwhile independent of whether we want to make the case in
the bug work? It doesn't actually fix it though, just make it show an error
instead of crashing. Whether we want to fall back to allowing a
non-X509TrustManagerExtensions-compatible trust manager on platforms where we
know to expect one or not allow that case is another question.

[Ryan Sleevi, 2014-06-03 17:47:24]

LGTM

I don't think we should support the non-Extensions TrustManager flow.

[Yaron, 2014-06-03 18:00:46]

lgtm

[davidben, 2014-06-03 18:01:56]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-06-03 18:02:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/316613002/1

[commit-bot: I haz the power, 2014-06-03 19:45:19]

Change committed as 274595