Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 3166035: add more ownership API methods to libcros (Closed)

Created:
10 years, 4 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
xiyuan, fes
CC:
chromium-os-reviews_chromium.org, DaveMoore
Visibility:
Public.

Description

add more ownership API methods to libcros BUG=4488 TEST=emerge, use login_drive to send calls to the live session_manager Change-Id: I0e9e64a192b79fb3d15d98a911a040062a0eef31

Patch Set 1 #

Patch Set 2 : Forgot to INIT_FUNC some new stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -34 lines) Patch
M chromeos_cros_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos_login.h View 3 chunks +16 lines, -3 lines 0 comments Download
M chromeos_login.cc View 7 chunks +150 lines, -27 lines 0 comments Download
M drive_login.cc View 1 chunk +11 lines, -1 line 0 comments Download
M load.cc View 1 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Chris Masone
10 years, 4 months ago (2010-08-26 00:44:26 UTC) #1
fes
LGTM
10 years, 4 months ago (2010-08-26 03:57:45 UTC) #2
xiyuan
Does the api provide support to enumerate the user whitelist? I am asking because the ...
10 years, 4 months ago (2010-08-26 16:29:13 UTC) #3
Chris Masone
It doesn't. Do you need me to provide that? File an issue on me if ...
10 years, 4 months ago (2010-08-26 16:34:04 UTC) #4
xiyuan
Yes, need that feature and also need a way to get the current user and ...
10 years, 4 months ago (2010-08-26 16:43:35 UTC) #5
Chris Masone
I think I've said before that I don't know how to get the current user, ...
10 years, 4 months ago (2010-08-26 16:47:19 UTC) #6
xiyuan
10 years, 4 months ago (2010-08-26 16:50:19 UTC) #7
Okay, I'll figure out how to get current user and will file a tracking bug for
determining whether the current user is owner or not.

On 2010/08/26 16:47:19, Chris Masone wrote:
> I think I've said before that I don't know how to get the current user, but
> the folks who've worked on the login UI or the screen locker probably have
> some way to do that.
> 
> I can provide a method to determine whether the current user is the owner,
> though.
> 
> On Thu, Aug 26, 2010 at 9:43 AM, <mailto:xiyuan@chromium.org> wrote:
> 
> > Yes, need that feature and also need a way to get the current user and
> > whether
> > the current user is owner or not.
> >
> >
> > http://codereview.chromium.org/3166035/show
> >
>

Powered by Google App Engine
This is Rietveld 408576698