Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 316583002: Correctly handle accessing a replaced Attr object's attribute value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ElementData.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index 812d4a447090b56997276d374bf386d1fd0697dd..669067f6cf6147b25115a7b2508eeed271c5fb64 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -323,7 +323,7 @@ void HTMLSelectElement::parseAttribute(const QualifiedName& name, const AtomicSt
AtomicString attrSize = AtomicString::number(size);
if (attrSize != value) {
// FIXME: This is horribly factored.
- if (Attribute* sizeAttribute = ensureUniqueElementData().getAttributeItem(sizeAttr))
+ if (Attribute* sizeAttribute = ensureUniqueElementData().getAttributeItem(sizeAttr, true))
Inactive 2014/06/03 15:11:39 Gosh, another boolean argument :) Could we make th
sof 2014/06/03 15:21:50 That would break with the convention followed else
sizeAttribute->setValue(attrSize);
}
size = max(size, 1);
« no previous file with comments | « Source/core/dom/ElementData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698