Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/core/dom/ElementData.h

Issue 316583002: Correctly handle accessing a replaced Attr object's attribute value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 class UniqueElementData FINAL : public ElementData { 143 class UniqueElementData FINAL : public ElementData {
144 public: 144 public:
145 static PassRefPtr<UniqueElementData> create(); 145 static PassRefPtr<UniqueElementData> create();
146 PassRefPtr<ShareableElementData> makeShareableCopy() const; 146 PassRefPtr<ShareableElementData> makeShareableCopy() const;
147 147
148 // These functions do no error/duplicate checking. 148 // These functions do no error/duplicate checking.
149 void addAttribute(const QualifiedName&, const AtomicString&); 149 void addAttribute(const QualifiedName&, const AtomicString&);
150 void removeAttribute(size_t index); 150 void removeAttribute(size_t index);
151 151
152 Attribute& attributeItem(unsigned index); 152 Attribute& attributeItem(unsigned index);
153 Attribute* getAttributeItem(const QualifiedName&); 153 Attribute* getAttributeItem(const QualifiedName&, bool shouldIgnoreCase);
154 154
155 UniqueElementData(); 155 UniqueElementData();
156 explicit UniqueElementData(const ShareableElementData&); 156 explicit UniqueElementData(const ShareableElementData&);
157 explicit UniqueElementData(const UniqueElementData&); 157 explicit UniqueElementData(const UniqueElementData&);
158 158
159 // FIXME: We might want to support sharing element data for elements with 159 // FIXME: We might want to support sharing element data for elements with
160 // presentation attribute style. Lots of table cells likely have the same 160 // presentation attribute style. Lots of table cells likely have the same
161 // attributes. Most modern pages don't use presentation attributes though 161 // attributes. Most modern pages don't use presentation attributes though
162 // so this might not make sense. 162 // so this might not make sense.
163 mutable RefPtr<StylePropertySet> m_presentationAttributeStyle; 163 mutable RefPtr<StylePropertySet> m_presentationAttributeStyle;
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 } 270 }
271 271
272 inline Attribute& UniqueElementData::attributeItem(unsigned index) 272 inline Attribute& UniqueElementData::attributeItem(unsigned index)
273 { 273 {
274 return m_attributeVector.at(index); 274 return m_attributeVector.at(index);
275 } 275 }
276 276
277 } // namespace WebCore 277 } // namespace WebCore
278 278
279 #endif // ElementData_h 279 #endif // ElementData_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698