Issue 316553005: Timeline: add trace event to style/category mapping to TracingTimelineUIUtils

Issue 316553005: Timeline: add trace event to style/category mapping to TracingTimelineUIUtils (Closed)

Created:
6 years, 6 months ago by caseq

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: add trace event to style/category mapping to TracingTimelineUIUtils We used to rely on timeline record to timeline category mapping, which is not entirely correct, since the set of trace events is slightly different. Let's fork the style map for the time being. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175481

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -3 lines)			Patch
	M	Source/devtools/front_end/timeline/TracingTimelineModel.js	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/devtools/front_end/timeline/TracingTimelineUIUtils.js	View	1	3 chunks	+99 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

caseq

This one is on top of https://codereview.chromium.org/307353004/

6 years, 6 months ago (2014-06-03 17:01:59 UTC) #1

yurys

lgtm https://codereview.chromium.org/316553005/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js File Source/devtools/front_end/timeline/TracingTimelineUIUtils.js (right): https://codereview.chromium.org/316553005/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js#newcode23 Source/devtools/front_end/timeline/TracingTimelineUIUtils.js:23: eventStyles[recordTypes.Program] = { title: WebInspector.UIString("Other"), category: categories["other"] }; ...

6 years, 6 months ago (2014-06-04 06:56:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/316553005/20001

6 years, 6 months ago (2014-06-04 11:41:41 UTC) #4

Message was sent while issue was closed.

Change committed as 175481

Expand Messages | Collapse Messages