Issue 316553002: Convert format of pixels read from GL to BGRA on CPU if necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316553002: Convert format of pixels read from GL to BGRA on CPU if necessary (Closed)

Created:
6 years, 6 months ago by oetuaho-nv

Modified:
6 years, 6 months ago

Reviewers:
wjia(left Chromium), sheu, Adam Rice, Ami GONE FROM CHROMIUM, piman

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Convert format of pixels read from GL to BGRA on CPU if necessary ReadPixels with format GL_BGRA_EXT is not necessarily supported by the GLES2-based GPU command buffer. The support for this format needs to be explicitly queried, and if it is not supported, the pixels need to be converted from RGBA to BGRA on the CPU if a BGRA result is desired. BUG=380129 TEST=WebGL conformance tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274847

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	content/renderer/media/renderer_gpu_video_accelerator_factories.cc	View		2 chunks	+28 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM! We could benefit from caching the query, but since it's a slow path it ...

6 years, 6 months ago (2014-06-04 13:26:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/316553002/1

6 years, 6 months ago (2014-06-04 13:31:33 UTC) #4

oetuaho-nv

Yep, I hope we'll get rid of this path entirely eventually in favor of keeping ...

6 years, 6 months ago (2014-06-04 13:32:46 UTC) #5

Message was sent while issue was closed.

Change committed as 274847

Expand Messages | Collapse Messages