Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 316533002: Fix PathTracer. (Closed)

Created:
6 years, 6 months ago by Igor Sheludko
Modified:
6 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix PathTracer. When tracing, we abuse the map for marking, thereby mutating it. HeapObject::map() takes care of recovering unabused value. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M src/heap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap.cc View 4 chunks +18 lines, -27 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 6 months ago (2014-06-03 08:01:31 UTC) #1
Yang
On 2014/06/03 08:01:31, Igor Sheludko wrote: > PTAL lgtm.
6 years, 6 months ago (2014-06-03 08:14:46 UTC) #2
Igor Sheludko
6 years, 6 months ago (2014-06-03 08:28:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698