Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 316503002: [Mac] Change --apps-keep-chrome-alive notification icon to the Chrome icon. (Closed)

Created:
6 years, 6 months ago by jackhou1
Modified:
6 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Change --apps-keep-chrome-alive notification icon to the Chrome icon. Previously this had the default app icon (rounded rectangle). In future we may show the icon of the specific apps that are running. BUG=333429 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jackhou1
6 years, 6 months ago (2014-06-03 06:04:02 UTC) #1
tapted
lgtm - I guess ideally we would put the app icon there if there was ...
6 years, 6 months ago (2014-06-03 06:29:40 UTC) #2
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 6 months ago (2014-06-03 06:55:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/316503002/1
6 years, 6 months ago (2014-06-03 06:57:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 13:25:19 UTC) #5
Message was sent while issue was closed.
Change committed as 274505

Powered by Google App Engine
This is Rietveld 408576698