Issue 3165009: Convert TimeFormat (chrome/common/time_format.*) to string16 (from wstring).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3165009: Convert TimeFormat (chrome/common/time_format.*) to string16 (from wstring). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by viettrungluu

Modified:
3 years, 11 months ago

Reviewers:
Lei Zhang, Miranda Callahan, Evan Martin

CC:
chromium-reviews, ncarter, idana, Raghu Simha, Paul Godavari, davemoore+watch_chromium.org, Paweł Hajdan Jr., ben+cc_chromium.org, timsteele

Visibility:
Public.

Convert TimeFormat (chrome/common/time_format.*) to string16 (from wstring). (Also do some drive-bys.) BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55842

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -96 lines)			Patch
M	chrome/browser/chromeos/low_battery_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/history2_ui.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/dom_ui/history_ui.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/download/download_item_model.cc	View	1 2	5 chunks	+17 lines, -15 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	1 2	4 chunks	+27 lines, -25 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/time_format.h	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/common/time_format.cc	View		5 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/common/time_format_unittest.cc	View		3 chunks	+24 lines, -21 lines	0 comments	Download

Trybot results: linux_chromeos win linux mac

Total messages: 2 (0 generated)

lgtm