Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 316443004: Oilpan: Remove ref counting from EventTarget and all uses of Pass/RefPtr<EventTarget>. (Closed)

Created:
6 years, 6 months ago by zerny-chromium
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, blink-reviews-events_chromium.org, alecflett, sof, eae+blinkwatch, ericu+idb_chromium.org, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org, Raymond Toy, rwlbuis
Visibility:
Public.

Description

Oilpan: Remove ref counting from EventTarget and all uses of Pass/RefPtr<EventTarget>. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175464

Patch Set 1 #

Total comments: 4

Patch Set 2 : dbl trace #

Total comments: 4

Patch Set 3 : dead code #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -52 lines) Patch
M Source/bindings/v8/Dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Touch.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Touch.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/events/Event.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/Event.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTarget.h View 4 chunks +15 lines, -0 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/FocusEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/FocusEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/GenericEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseEvent.h View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/MouseEvent.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/events/NodeEventContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/NodeEventContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/events/TreeScopeEventContext.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/WindowEventContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/ime/InputMethodContext.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequestUpload.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBEventDispatcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBEventDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
zerny-chromium
This CL depends on the EventTarget IDL patch: https://codereview.chromium.org/302263004/ PTAL.
6 years, 6 months ago (2014-06-03 09:26:44 UTC) #1
haraken
LGTM https://codereview.chromium.org/316443004/diff/1/Source/core/events/EventPath.cpp File Source/core/events/EventPath.cpp (right): https://codereview.chromium.org/316443004/diff/1/Source/core/events/EventPath.cpp#newcode371 Source/core/events/EventPath.cpp:371: visitor->trace(m_nodeEventContexts); You're tracing twice :) https://codereview.chromium.org/316443004/diff/1/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp ...
6 years, 6 months ago (2014-06-03 09:47:07 UTC) #2
zerny-chromium
Odd with the double tracing. Thanks for noticing! https://codereview.chromium.org/316443004/diff/1/Source/core/events/EventPath.cpp File Source/core/events/EventPath.cpp (right): https://codereview.chromium.org/316443004/diff/1/Source/core/events/EventPath.cpp#newcode371 Source/core/events/EventPath.cpp:371: visitor->trace(m_nodeEventContexts); ...
6 years, 6 months ago (2014-06-03 10:11:05 UTC) #3
sof
https://codereview.chromium.org/316443004/diff/20001/Source/core/xml/XMLHttpRequestUpload.h File Source/core/xml/XMLHttpRequestUpload.h (right): https://codereview.chromium.org/316443004/diff/20001/Source/core/xml/XMLHttpRequestUpload.h#newcode55 Source/core/xml/XMLHttpRequestUpload.h:55: using RefCountedGarbageCollected::ref; Still needed?
6 years, 6 months ago (2014-06-03 10:13:43 UTC) #4
sof
https://codereview.chromium.org/316443004/diff/20001/Source/core/html/ime/InputMethodContext.h File Source/core/html/ime/InputMethodContext.h (right): https://codereview.chromium.org/316443004/diff/20001/Source/core/html/ime/InputMethodContext.h#newcode56 Source/core/html/ime/InputMethodContext.h:56: using RefCountedGarbageCollected<InputMethodContext>::ref; Still needed/used?
6 years, 6 months ago (2014-06-03 10:34:35 UTC) #5
zerny-chromium
https://codereview.chromium.org/316443004/diff/20001/Source/core/html/ime/InputMethodContext.h File Source/core/html/ime/InputMethodContext.h (right): https://codereview.chromium.org/316443004/diff/20001/Source/core/html/ime/InputMethodContext.h#newcode56 Source/core/html/ime/InputMethodContext.h:56: using RefCountedGarbageCollected<InputMethodContext>::ref; On 2014/06/03 10:34:36, sof wrote: > Still ...
6 years, 6 months ago (2014-06-03 11:01:02 UTC) #6
sof
lgtm
6 years, 6 months ago (2014-06-03 11:07:12 UTC) #7
wibling-chromium
lgtm2
6 years, 6 months ago (2014-06-03 11:13:10 UTC) #8
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 6 months ago (2014-06-04 05:20:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/316443004/50001
6 years, 6 months ago (2014-06-04 05:20:58 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-04 06:48:04 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 08:35:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10571)
6 years, 6 months ago (2014-06-04 08:35:47 UTC) #13
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 6 months ago (2014-06-04 08:40:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/316443004/50001
6 years, 6 months ago (2014-06-04 08:41:26 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:46:20 UTC) #16
Message was sent while issue was closed. 
Change committed as 175464

Powered by Google App Engine
This is Rietveld 408576698