Issue 316413002: Revert 275293 "Add authentication support to AttachmentUploaderI..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316413002: Revert 275293 "Add authentication support to AttachmentUploaderI..." (Closed)

Created:
6 years, 6 months ago by Timur Iskhodzhanov

Modified:
6 years, 6 months ago

Reviewers:
maniscalco

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 275293 "Add authentication support to AttachmentUploaderI..." BUG=381581 > Add authentication support to AttachmentUploaderImpl. > > Update AUI to request an access token and send an Authorization header > with each requests. If the server responds with 401, AUI invalidates > its token, but does not retry. Retries will be implemented in a future > CL, probably at a higher level. > > BUG=371516 > > Review URL: https://codereview.chromium.org/304253010 TBR=maniscalco@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275357

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -473 lines)			Patch
M	trunk/src/sync/internal_api/attachments/attachment_uploader_impl.cc	View	7 chunks	+36 lines, -122 lines	0 comments	Download
M	trunk/src/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc	View	13 chunks	+18 lines, -328 lines	0 comments	Download
M	trunk/src/sync/internal_api/public/attachments/attachment_uploader_impl.h	View	3 chunks	+4 lines, -22 lines	0 comments	Download
M	trunk/src/sync/sync_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

6 years, 6 months ago (2014-06-06 08:51:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r275357 (tree was closed).

Expand Messages | Collapse Messages