Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 316403002: DevTools: cleanup debugger tests. (Closed)

Created:
6 years, 6 months ago by loislo
Modified:
6 years, 6 months ago
Reviewers:
vsevik, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: cleanup debugger tests. Debugger is always enabled at the moment when we run the test so we don't need to check that and dump the message. Also we don't need to disable it manually at the end because it might hide an error as it happens with debugger-step-into-custom-element-callbacks.html BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175870

Patch Set 1 #

Patch Set 2 : Debugger was enabled text was removed #

Patch Set 3 : minor change #

Total comments: 5

Patch Set 4 : comments addressed #

Total comments: 3

Patch Set 5 : comments addressed #

Patch Set 6 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -243 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector-enabled/dynamic-scripts-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/debugger-test.js View 1 2 3 1 chunk +6 lines, -39 lines 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/load-resource-when-paused-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/search/search-in-concatenated-script-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/search/search-in-script-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-api-on-call-frame-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-error-on-call-frame-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-resources.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-resources-expected.txt View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-eval-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-middle-run-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-mutation-observer-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-scopes-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-xhrs-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/breakpoint-manager-listeners-count-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/callstack-placards-discarded-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/copy-stack-trace-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/custom-element-lifecycle-events-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debug-console-command-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debug-inlined-scripts-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debug-inlined-scripts-fragment-id-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-activation-crash-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-activation-crash2-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-autocontinue-on-syntax-error-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-breakpoints-not-activated-on-reload-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-change-variable-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-command-line-api-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-completions-on-call-frame-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-eval-on-call-frame-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-eval-while-paused-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-expand-scope-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-no-nested-pause-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-no-pause-on-antibreakpoint-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-in-eval-script-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-in-internal-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-on-blocked-event-handler-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-on-blocked-script-injection-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-on-blocked-script-url-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-on-debugger-statement-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-on-exception-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-on-failed-assertion-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-with-overrides-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-proto-property-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-reload-on-pause-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-return-value-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-script-preprocessor-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-scripts-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-scripts-reload-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-set-breakpoint-regex-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-step-in-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-step-into-event-listener-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-step-out-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-step-over-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-suspend-active-dom-objects-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/dom-breakpoints-editing-dom-from-inspector-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/dom-breakpoints-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/dynamic-script-tag-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/dynamic-scripts-breakpoints-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/dynamic-scripts-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/eval-on-pause-blocked-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-dom-xhr-event-breakpoints-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-skip-step-in-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-steppings-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-with-async-callstack-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/function-details-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/function-display-name-call-stack-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/js-with-inline-stylesheets-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/linkifier-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit-breakpoints-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit-no-reveal-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/monitor-console-command-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/mutation-observer-suspend-while-paused-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/open-close-open-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/pause-in-inline-script-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/pause-in-internal-script.html View 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/pause-in-internal-script-expected.txt View 1 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/properties-special-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/reveal-execution-line-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/reveal-not-skipped-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-1-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-2-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-3-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-4-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-console-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-search-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/script-snippet-model-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/selected-call-frame-after-formatting-source-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/set-breakpoint-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/skip-pauses-until-reload-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/source-frame-count-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/source-frame-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/source-url-comment-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/step-through-event-listeners-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/watch-expressions-panel-switch-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/watch-expressions-preserve-expansion-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/xhr-breakpoints-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
loislo
6 years, 6 months ago (2014-06-06 08:52:35 UTC) #1
yurys
https://codereview.chromium.org/316403002/diff/40001/LayoutTests/http/tests/inspector/debugger-test.js File LayoutTests/http/tests/inspector/debugger-test.js (right): https://codereview.chromium.org/316403002/diff/40001/LayoutTests/http/tests/inspector/debugger-test.js#newcode8 LayoutTests/http/tests/inspector/debugger-test.js:8: Let's add an assert that WebInspector.debuggerModel.debuggerEnabled() here. https://codereview.chromium.org/316403002/diff/40001/LayoutTests/http/tests/inspector/inspector-test.js File ...
6 years, 6 months ago (2014-06-06 08:59:58 UTC) #2
vsevik
https://codereview.chromium.org/316403002/diff/50104/LayoutTests/http/tests/inspector/inspector-test.js File LayoutTests/http/tests/inspector/inspector-test.js (right): https://codereview.chromium.org/316403002/diff/50104/LayoutTests/http/tests/inspector/inspector-test.js#newcode699 LayoutTests/http/tests/inspector/inspector-test.js:699: closeInspectorAndNotifyDone(); I don't really understand this code, but why ...
6 years, 6 months ago (2014-06-06 11:51:23 UTC) #3
loislo
https://codereview.chromium.org/316403002/diff/40001/LayoutTests/http/tests/inspector/debugger-test.js File LayoutTests/http/tests/inspector/debugger-test.js (right): https://codereview.chromium.org/316403002/diff/40001/LayoutTests/http/tests/inspector/debugger-test.js#newcode8 LayoutTests/http/tests/inspector/debugger-test.js:8: On 2014/06/06 08:59:58, yurys wrote: > Let's add an ...
6 years, 6 months ago (2014-06-06 12:41:13 UTC) #4
pfeldman
https://codereview.chromium.org/316403002/diff/40001/LayoutTests/http/tests/inspector/inspector-test.js File LayoutTests/http/tests/inspector/inspector-test.js (left): https://codereview.chromium.org/316403002/diff/40001/LayoutTests/http/tests/inspector/inspector-test.js#oldcode701 LayoutTests/http/tests/inspector/inspector-test.js:701: setTimeout(closeInspectorAndNotifyDone, 0); i think yurys@ is right here and ...
6 years, 6 months ago (2014-06-06 13:24:15 UTC) #5
loislo
https://codereview.chromium.org/316403002/diff/50104/LayoutTests/inspector/extensions/extensions-resources.html File LayoutTests/inspector/extensions/extensions-resources.html (right): https://codereview.chromium.org/316403002/diff/50104/LayoutTests/inspector/extensions/extensions-resources.html#newcode164 LayoutTests/inspector/extensions/extensions-resources.html:164: evaluateOnFrontend("InspectorTest.completeDebuggerTest();", nextTest); On 2014/06/06 11:51:23, vsevik wrote: > I ...
6 years, 6 months ago (2014-06-06 13:48:25 UTC) #6
yurys
lgtm
6 years, 6 months ago (2014-06-09 15:16:55 UTC) #7
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-09 15:21:10 UTC) #8
loislo
The CQ bit was unchecked by loislo@chromium.org
6 years, 6 months ago (2014-06-09 15:21:12 UTC) #9
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-10 06:37:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/316403002/90001
6 years, 6 months ago (2014-06-10 06:38:02 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 07:47:06 UTC) #12
Message was sent while issue was closed. 
Change committed as 175870

Powered by Google App Engine
This is Rietveld 408576698