Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 316353004: Remove the report load timing field in ResourceRequest (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the report load timing field in ResourceRequest Since this field is always set to true before being used only in WebURLLoaderImpl, this CL removes it entirely. BUG=376025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176109

Patch Set 1 #

Patch Set 2 : Removing the reportLoadTiming field from ResourceRequest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M Source/core/fetch/ResourceLoader.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebURLRequest.cpp View 1 2 chunks +0 lines, -10 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebURLRequest.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
clamy
@ppi: PTAL
6 years, 6 months ago (2014-06-06 10:57:25 UTC) #1
ppi
lgtm, thanks!
6 years, 6 months ago (2014-06-06 15:18:16 UTC) #2
Nate Chapin
LGTM
6 years, 6 months ago (2014-06-06 16:15:23 UTC) #3
clamy
Thanks! As per jam@ suggestion, I have uploaded a new patch set which removes the ...
6 years, 6 months ago (2014-06-06 16:56:52 UTC) #4
clamy
@abarth: PTAL This involves changes to the public API.
6 years, 6 months ago (2014-06-10 15:15:44 UTC) #5
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-10 17:14:10 UTC) #6
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-11 09:07:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/316353004/20001
6 years, 6 months ago (2014-06-11 09:07:41 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-11 10:18:35 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 11:31:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11568)
6 years, 6 months ago (2014-06-11 11:31:12 UTC) #11
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-13 10:47:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/316353004/20001
6 years, 6 months ago (2014-06-13 10:48:00 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 11:35:31 UTC) #14
Message was sent while issue was closed.
Change committed as 176109

Powered by Google App Engine
This is Rietveld 408576698