Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: Source/core/css/RemoteFontFaceSource.h

Issue 316353003: Remove font fetching fallback for CORS failures (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add/Update tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSFontFaceSrcValue.cpp ('k') | Source/core/css/RemoteFontFaceSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RemoteFontFaceSource.h
diff --git a/Source/core/css/RemoteFontFaceSource.h b/Source/core/css/RemoteFontFaceSource.h
index c224fcd49015d3df32fbbb0232eb0f5488523001..f7d84ee5a3638b6199b2d659b5e790f5ab3127fa 100644
--- a/Source/core/css/RemoteFontFaceSource.h
+++ b/Source/core/css/RemoteFontFaceSource.h
@@ -33,7 +33,6 @@ public:
virtual void didStartFontLoad(FontResource*) OVERRIDE;
virtual void fontLoaded(FontResource*) OVERRIDE;
virtual void fontLoadWaitLimitExceeded(FontResource*) OVERRIDE;
- virtual void corsFailed(FontResource*) OVERRIDE;
// For UMA reporting
virtual bool hadBlankText() OVERRIDE { return m_histograms.hadBlankText(); }
@@ -49,18 +48,16 @@ protected:
private:
class FontLoadHistograms {
public:
- FontLoadHistograms() : m_loadStartTime(0), m_fallbackPaintTime(0), m_corsFailed(false) { }
+ FontLoadHistograms() : m_loadStartTime(0), m_fallbackPaintTime(0) { }
void loadStarted();
void fallbackFontPainted();
void recordRemoteFont(const FontResource*);
void recordFallbackTime(const FontResource*);
- void corsFailed() { m_corsFailed = true; }
bool hadBlankText() { return m_fallbackPaintTime; }
private:
const char* histogramName(const FontResource*);
double m_loadStartTime;
double m_fallbackPaintTime;
- bool m_corsFailed;
};
ResourcePtr<FontResource> m_font;
« no previous file with comments | « Source/core/css/CSSFontFaceSrcValue.cpp ('k') | Source/core/css/RemoteFontFaceSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698