Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 316353003: Remove font fetching fallback for CORS failures (Closed)

Created:
6 years, 6 months ago by bashi
Modified:
6 years, 6 months ago
CC:
blink-reviews, Nate Chapin, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove font fetching fallback for CORS failures We are going to disallow CORS-disabled font fetching. Also adding a test case to check whether CORS is working. BUG=286681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175927

Patch Set 1 #

Patch Set 2 : Add/Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -87 lines) Patch
M LayoutTests/http/tests/security/mixedContent/insecure-font-in-main-frame-expected.txt View 1 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-font.html View 1 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/webfont/webfont-cors.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/webfont/webfont-cors-expected.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFace.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontFace.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/RemoteFontFaceSource.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/css/RemoteFontFaceSource.cpp View 3 chunks +1 line, -31 lines 0 comments Download
M Source/core/fetch/FontResource.h View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/fetch/FontResource.cpp View 2 chunks +2 lines, -10 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
bashi
6 years, 6 months ago (2014-06-06 07:09:48 UTC) #1
Kunihiko Sakamoto
non-owner LGTM
6 years, 6 months ago (2014-06-06 07:20:31 UTC) #2
dglazkov
lgtm
6 years, 6 months ago (2014-06-06 15:20:59 UTC) #3
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 6 months ago (2014-06-09 23:21:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/316353003/20001
6 years, 6 months ago (2014-06-09 23:22:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-09 23:31:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 23:31:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14683)
6 years, 6 months ago (2014-06-09 23:31:44 UTC) #8
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 6 months ago (2014-06-09 23:44:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/316353003/20001
6 years, 6 months ago (2014-06-09 23:45:12 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-09 23:45:24 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 23:45:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14683)
6 years, 6 months ago (2014-06-09 23:45:36 UTC) #13
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 6 months ago (2014-06-10 23:17:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/316353003/20001
6 years, 6 months ago (2014-06-10 23:18:55 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 23:19:42 UTC) #16
Message was sent while issue was closed. 
Change committed as 175927

Powered by Google App Engine
This is Rietveld 408576698