Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2631)

Unified Diff: slave/skia_slave_scripts/compare_gms.py

Issue 316333002: display "latest GM failures" link in its own line under build step Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: slave/skia_slave_scripts/compare_gms.py
diff --git a/slave/skia_slave_scripts/compare_gms.py b/slave/skia_slave_scripts/compare_gms.py
index a889b4a87d9b2cda3b17192026fe60cc19ca8de7..352906a1f93a34528537b54c5aeff91b3d49bdb0 100644
--- a/slave/skia_slave_scripts/compare_gms.py
+++ b/slave/skia_slave_scripts/compare_gms.py
@@ -31,10 +31,9 @@ class CompareGMs(BuildStep):
# CWD is in PYTHONPATH, and BuildStep.__init__ may change the CWD.
from gm import display_json_results
success = display_json_results.Display(json_summary_path)
- print ('%s<a href="%s?resultsToLoad=/results/failures&builder=%s">'
- 'link</a>' % (
- skia_vars.GetGlobalVariable('latest_gm_failures_preamble'),
- LIVE_REBASELINE_SERVER_BASEURL, self._builder_name))
+ print ('%s%s?resultsToLoad=/results/failures&builder=%s' % (
+ skia_vars.GetGlobalVariable('latest_gm_failures_preamble'),
+ LIVE_REBASELINE_SERVER_BASEURL, self._builder_name))
if not success:
if self._builder_name in may_fail_with_warning:
raise BuildStepWarning('Expectations mismatch in %s!' %

Powered by Google App Engine
This is Rietveld 408576698