Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 316323002: Introduces ActivityFactory for SampleActivity. (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
Reviewers:
oshima, reed1
CC:
chromium-reviews
Visibility:
Public.

Description

Introduces ActivityFactory for SampleActivity. BUG=None R=oshima@chromium.org TBR=reed@google.com TEST=athena_shell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275393

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -105 lines) Patch
M athena/athena.gyp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M athena/main/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M athena/main/athena_launcher.h View 1 chunk +3 lines, -1 line 0 comments Download
M athena/main/athena_launcher.cc View 2 chunks +4 lines, -1 line 0 comments Download
M athena/main/athena_main.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M athena/main/athena_main.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M athena/main/athena_shell.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
D athena/main/sample_activity.h View 1 chunk +0 lines, -35 lines 0 comments Download
D athena/main/sample_activity.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M athena/test/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/test/athena_test_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + athena/test/sample_activity.h View 2 chunks +11 lines, -5 lines 0 comments Download
A + athena/test/sample_activity.cc View 2 chunks +7 lines, -1 line 0 comments Download
A + athena/test/sample_activity_factory.h View 1 chunk +9 lines, -8 lines 0 comments Download
A athena/test/sample_activity_factory.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
6 years, 6 months ago (2014-06-05 21:52:26 UTC) #1
oshima
nice, lgtm https://codereview.chromium.org/316323002/diff/1/athena/main/athena_shell.cc File athena/main/athena_shell.cc (right): https://codereview.chromium.org/316323002/diff/1/athena/main/athena_shell.cc#newcode36 athena/main/athena_shell.cc:36: athena::ActivityFactory::Get()->CreateWebActivity(NULL, GURL())); maybe put real url and ...
6 years, 6 months ago (2014-06-05 23:49:20 UTC) #2
oshima
one more thing https://codereview.chromium.org/316323002/diff/1/athena/main/athena_shell.cc File athena/main/athena_shell.cc (right): https://codereview.chromium.org/316323002/diff/1/athena/main/athena_shell.cc#newcode14 athena/main/athena_shell.cc:14: #include "third_party/skia/include/core/SkColor.h" can you remove this ...
6 years, 6 months ago (2014-06-05 23:50:54 UTC) #3
Jun Mukai
https://codereview.chromium.org/316323002/diff/1/athena/main/athena_shell.cc File athena/main/athena_shell.cc (right): https://codereview.chromium.org/316323002/diff/1/athena/main/athena_shell.cc#newcode14 athena/main/athena_shell.cc:14: #include "third_party/skia/include/core/SkColor.h" On 2014/06/05 23:50:53, oshima wrote: > can ...
6 years, 6 months ago (2014-06-06 00:14:43 UTC) #4
Jun Mukai
TBR=reed for DEPS change (athena/test +third_party/skia)
6 years, 6 months ago (2014-06-06 00:15:24 UTC) #5
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-06 00:15:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/316323002/20001
6 years, 6 months ago (2014-06-06 00:17:57 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 10:59:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 275393

Powered by Google App Engine
This is Rietveld 408576698