Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 316303002: Enable floating point touch co-ordinates in EventSender (Closed)

Created:
6 years, 6 months ago by Rick Byers
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Enable floating point touch co-ordinates in EventSender WebTouchPoint has used floating point co-ordinate and radius values for awhile, but we've never allowed generating non-integer values via EventSender. BUG=323935 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/shell/renderer/test_runner/event_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Rick Byers
Dirk, can you please review this little EventSender fix? It's a prerequisite for my blink ...
6 years, 6 months ago (2014-06-05 21:28:08 UTC) #1
Dirk Pranke
seems fine on its own, but I'm not sure I understand how you'll land this ...
6 years, 6 months ago (2014-06-05 21:35:28 UTC) #2
Rick Byers
On 2014/06/05 21:35:28, Dirk Pranke wrote: > seems fine on its own, but I'm not ...
6 years, 6 months ago (2014-06-05 21:48:23 UTC) #3
Dirk Pranke
On 2014/06/05 21:48:23, Rick Byers wrote: > On 2014/06/05 21:35:28, Dirk Pranke wrote: > > ...
6 years, 6 months ago (2014-06-05 21:54:03 UTC) #4
Rick Byers
On 2014/06/05 21:54:03, Dirk Pranke wrote: > On 2014/06/05 21:48:23, Rick Byers wrote: > > ...
6 years, 6 months ago (2014-06-05 22:03:40 UTC) #5
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 6 months ago (2014-06-05 22:03:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/316303002/1
6 years, 6 months ago (2014-06-05 22:08:04 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:25:10 UTC) #8
Message was sent while issue was closed.
Change committed as 275340

Powered by Google App Engine
This is Rietveld 408576698