Issue 3163010: Initialize all data members in HTTPResponseInfo's new ctor and remove the rel...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3163010: Initialize all data members in HTTPResponseInfo's new ctor and remove the rel... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by michaeln

Modified:
4 years ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, cbentzel+watch_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Initialize all data members in HTTPResponseInfo's new ctor and remove the related valgrind suppression. BUG=51940 TEST=n/a Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56068

Patch Set 1 #

Patch Set 2 : '' #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	net/http/http_response_info.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -13 lines	0 comments	Download

Trybot results: linux_valgrind win linux mac mac_valgrind

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

4 years, 9 months ago (2010-08-12 22:02:50 UTC) #2

LGTM

On Thu, Aug 12, 2010 at 2:37 PM,  <michaeln@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> please take a look
>
> Description:
> Initialize all data members in HTTPResponseInfo's new ctor and remove the
> related valgrind suppression.
>
> BUG=51940
> TEST=n/a
>
>
> Please review this at http://codereview.chromium.org/3163010/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     net/http/http_response_info.cc
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: net/http/http_response_info.cc
> ===================================================================
> --- net/http/http_response_info.cc      (revision 55917)
> +++ net/http/http_response_info.cc      (working copy)
> @@ -71,6 +71,7 @@
>     : was_cached(rhs.was_cached),
>       was_fetched_via_spdy(rhs.was_fetched_via_spdy),
>       was_npn_negotiated(rhs.was_npn_negotiated),
> +
>  was_alternate_protocol_available(rhs.was_alternate_protocol_available),
>       was_fetched_via_proxy(rhs.was_fetched_via_proxy),
>       request_time(rhs.request_time),
>       response_time(rhs.response_time),
> @@ -89,6 +90,7 @@
>   was_cached = rhs.was_cached;
>   was_fetched_via_spdy = rhs.was_fetched_via_spdy;
>   was_npn_negotiated = rhs.was_npn_negotiated;
> +  was_alternate_protocol_available = rhs.was_alternate_protocol_available;
>   was_fetched_via_proxy = rhs.was_fetched_via_proxy;
>   request_time = rhs.request_time;
>   response_time = rhs.response_time;
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 55952)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -4103,16 +4103,3 @@
>    fun:_ZN9TestShell21BindJSObjectsToWindowEPN6WebKit8WebFrameE
>    fun:_ZN19TestWebViewDelegate20didClearWindowObjectEPN6WebKit8WebFrameE
>  }
> -{
> -   bug_51940
> -   Memcheck:Param
> -   pwrite64(buf)
> -   fun:pwrite64
> -   fun:_ZN10disk_cache4File5WriteEPKvjj
> -   fun:_ZN10disk_cache4File5WriteEPKvjjPNS_14FileIOCallbackEPb
> -   fun:_ZN10disk_cache9EntryImpl5FlushEiib
> -   fun:_ZN10disk_cache9EntryImplD0Ev
> -   fun:_ZN4base10RefCountedIN10disk_cache9EntryImplEE7ReleaseEv
> -   fun:_ZN10disk_cache9BackendIO23ExecuteBackendOperationEv
> -   fun:_ZN10disk_cache9BackendIO16ExecuteOperationEv
> -}
>
>
>

Expand Messages | Collapse Messages