Issue 3163008: Removed a command which resulted in a crash....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3163008: Removed a command which resulted in a crash.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Andrew Bonventre (Bons)

Modified:
3 years, 10 months ago

Reviewers:
pink, shreyas

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Removed a command which resulted in a crash. Removed Unnescessary code and also refactored some. Added tests. Added example AppleScripts. original patch from shreyas. BUG=none TEST=updates some unit tests and adds some. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55946

Patch Set 1 #

Total comments: 1

Patch Set 2 : Typo fixed. #

Patch Set 3 : updated. #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -42 lines)			Patch
M	chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm	View	1 2 3 4	2 chunks	+17 lines, -22 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/browsercrapplication+applescript.mm	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/applescript/browsercrapplication+applescript_test.mm	View	1 2 3 4	1 chunk	+107 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/applescript/examples/app_info.applescript	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/applescript/examples/bookmark_current_tabs.applescript	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/applescript/examples/quit_app.applescript	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/applescript/examples/tab_navigation.applescript	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/applescript/examples/window_creation.applescript	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/applescript/examples/window_operations.applescript	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/scripting.sdef	View	1 2 3 4	3 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/window_applescript.mm	View	1 2 3 4	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/window_applescript_test.mm	View	1 2 3 4	3 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download

Trybot results: mac linux win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew Bonventre (Bons)

shreyas' original patch. If try bots look good I'm going to commit since it lgtm. ...

4 years, 9 months ago (2010-08-12 05:51:53 UTC) #1

pink

4 years, 9 months ago (2010-08-12 15:59:43 UTC) #2

lgtm with one comment

http://codereview.chromium.org/3163008/diff/1/8
File chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm
(right):

http://codereview.chromium.org/3163008/diff/1/8#newcode99
chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm:99: N
typo?

Expand Messages | Collapse Messages