Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2420)

Unified Diff: chrome/browser/speech/speech_recognition_request.cc

Issue 3163004: Address Andrei's comments from CL 3164002 (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/speech/speech_recognition_request.cc
diff --git a/chrome/browser/speech/speech_recognition_request.cc b/chrome/browser/speech/speech_recognition_request.cc
index 7a26d22f9dfa7baea81351495fb4759f24841a9c..9e6cc41da4afe00b171493366e7463a8daf65bfe 100644
--- a/chrome/browser/speech/speech_recognition_request.cc
+++ b/chrome/browser/speech/speech_recognition_request.cc
@@ -108,8 +108,12 @@ bool SpeechRecognitionRequest::Send(const std::string& audio_data) {
url_fetcher_id_for_tests, url_, URLFetcher::POST, this));
url_fetcher_->set_upload_data(kMimeRawAudio, audio_data);
url_fetcher_->set_request_context(url_context_);
+
+ // The speech recognition API does not require user identification as part
+ // of requests, so we don't send cookies or auth data for these requests to
+ // prevent any accidental connection between users who are logged into the
+ // domain for other services (e.g. bookmark sync) with the speech requests.
url_fetcher_->set_load_flags(
- net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE |
net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SEND_AUTH_DATA);
url_fetcher_->Start();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698