Issue 3163001: Enable tcmalloc on Valgrind bots....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3163001: Enable tcmalloc on Valgrind bots.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Alexander Potapenko

Modified:
4 years ago

Reviewers:
Mike Belshe, Nicolas Sylvain, bevc, willchan no longer on Chromium, nsylvain

CC:
chromium-reviews, Nicolas Sylvain, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/buildbot/

Visibility:
Public.

Enable tcmalloc on Valgrind bots. As of r55206 Valgrind should handle tcmalloc without any problems. TEST=Valgrind bots stay sane BUG=49757, 31951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55708

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	scripts/master/factory/chromium_factory.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results:

Total messages: 2 (0 generated)

Alexander Potapenko

I'm going to enable TCMalloc on Valgrind bots back. We'll have to "make reconfig" once ...

4 years, 9 months ago (2010-08-10 12:53:10 UTC) #1

LGTM