Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 316293002: Make realtimeanalyser-fft-scaling test more robust (Closed)

Created:
6 years, 6 months ago by Raymond Toy
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Make realtimeanalyser-fft-scaling test more robust The failures on Windows Debug is probably due to a timing issue where the FFT samples were grabbed at an unexpected time. If the grabbed time sample isn't a multiple of a full cycle and doesn't start at 0, the FFT result is affected which can change the peak position and value. This is aggravated by the Blackman window that is applied which smears the peak out anyway. This is partly due to the use of one context for all of the different-sized analyzers. This CL replaces that with a separate offline context for each analyzer test that should guarantee that right time samples are used. BUG=349523 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -94 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webaudio/realtimeanalyser-fft-scaling.html View 3 chunks +87 lines, -79 lines 0 comments Download
M LayoutTests/webaudio/realtimeanalyser-fft-scaling-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Raymond Toy
PTAL
6 years, 6 months ago (2014-06-06 17:46:24 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 6 months ago (2014-06-06 22:04:51 UTC) #2
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 6 months ago (2014-06-09 16:45:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/316293002/1
6 years, 6 months ago (2014-06-09 16:45:41 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 17:46:07 UTC) #5
Message was sent while issue was closed.
Change committed as 175806

Powered by Google App Engine
This is Rietveld 408576698