Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 316273004: Faster GPU rect blur that doesn't require computing vertical and horizontal (Closed)

Created:
6 years, 6 months ago by humper
Modified:
6 years, 6 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, ernstm
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Faster GPU rect blur that doesn't require computing vertical and horizontal scanlines on the CPU first. Should make extremely large drop shadows fast again. BUG=skia: Committed: https://skia.googlesource.com/skia/+/fe689c46a764ded343e5028f79ead80c8b140b0f

Patch Set 1 #

Total comments: 1

Patch Set 2 : windows fixes #

Patch Set 3 : more windows fixes #

Patch Set 4 : missed a GM to ignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -94 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 8 chunks +97 lines, -94 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
humper
ptal. All GM changes are extremely minimal imperceptible noise.
6 years, 6 months ago (2014-06-05 19:51:41 UTC) #1
bsalomon
lgtm https://codereview.chromium.org/316273004/diff/1/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/316273004/diff/1/src/effects/SkBlurMaskFilter.cpp#newcode715 src/effects/SkBlurMaskFilter.cpp:715: key.fData32[1] = 1; you could just delete this ...
6 years, 6 months ago (2014-06-05 20:29:18 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-06-06 13:26:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/316273004/1
6 years, 6 months ago (2014-06-06 13:27:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 14:09:55 UTC) #5
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-06-06 14:30:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/316273004/20001
6 years, 6 months ago (2014-06-06 14:30:55 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 15:12:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 15:22:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.chromium (http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Trybot/builds/254)
6 years, 6 months ago (2014-06-06 15:22:16 UTC) #10
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-06-06 16:22:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/316273004/40001
6 years, 6 months ago (2014-06-06 16:23:26 UTC) #12
commit-bot: I haz the power
Change committed as fe689c46a764ded343e5028f79ead80c8b140b0f
6 years, 6 months ago (2014-06-06 16:48:43 UTC) #13
jvanverth1
6 years, 6 months ago (2014-06-06 18:01:46 UTC) #14
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/320563003/ by jvanverth@google.com.

The reason for reverting is: Many tree failures in RunTests (looks like
GLProgramsTest)..

Powered by Google App Engine
This is Rietveld 408576698