Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 316243002: Add date_synced to PasswordForm. (Closed)

Created:
6 years, 6 months ago by vasilii
Modified:
6 years, 6 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Add date_synced to PasswordForm. We need it for the "Remote unsync" project. If user accidentally signed-in in the library then he should be able to clean his passwords. date_synced designates the time the password was downloaded from the sync server. All passwords with (date_synced >= sign-in time) are to be deleted. BUG=362679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276445

Patch Set 1 #

Total comments: 2

Patch Set 2 : +comment #

Messages

Total messages: 7 (0 generated)
vasilii
Hi Garrett, please review. It's the first patch for the "Remote Unsync" project.
6 years, 6 months ago (2014-06-05 18:47:43 UTC) #1
Garrett Casto
lgtm https://codereview.chromium.org/316243002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/316243002/diff/1/components/password_manager/core/browser/login_database.cc#newcode201 components/password_manager/core/browser/login_database.cc:201: meta_table_.SetVersionNumber(5); Nit: Missing // Fall through.
6 years, 6 months ago (2014-06-06 17:40:08 UTC) #2
vasilii
https://codereview.chromium.org/316243002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/316243002/diff/1/components/password_manager/core/browser/login_database.cc#newcode201 components/password_manager/core/browser/login_database.cc:201: meta_table_.SetVersionNumber(5); On 2014/06/06 17:40:08, Garrett Casto wrote: > Nit: ...
6 years, 6 months ago (2014-06-11 08:24:12 UTC) #3
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 6 months ago (2014-06-11 08:24:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/316243002/20001
6 years, 6 months ago (2014-06-11 08:26:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 14:28:35 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 17:50:14 UTC) #7
Message was sent while issue was closed.
Change committed as 276445

Powered by Google App Engine
This is Rietveld 408576698